Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: BenchmarkHandshakeServer failures #68418

Open
gopherbot opened this issue Jul 15, 2024 · 2 comments
Open

crypto/tls: BenchmarkHandshakeServer failures #68418

gopherbot opened this issue Jul 15, 2024 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Jul 15, 2024 •
edited by cherrymui
Loading 

#!watchflakes
default <- pkg == "crypto/tls" && test ~ `BenchmarkHandshakeServer`

Issue created automatically to collect these failures.

Example (log):

=== RUN   BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521
BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521
--- FAIL: BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 15, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "crypto/tls" && test == "BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521"
2024-06-04 23:33 gotip-darwin-amd64-race go@1b07b774 crypto/tls.BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521 (log) 
=== RUN   BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521
BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521
--- FAIL: BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521
2024-06-05 15:56 gotip-darwin-amd64-race go@f3ae1356 crypto/tls.BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521 (log) 
=== RUN   BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521
BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521
--- FAIL: BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521
2024-06-18 19:07 gotip-darwin-amd64-race go@2b12bbcb crypto/tls.BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521 (log) 
=== RUN   BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521
BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521
--- FAIL: BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521

— watchflakes

@cherrymui cherrymui mentioned this issue Jul 29, 2024
Closed
@cherrymui cherrymui changed the title crypto/tls: BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521 failures crypto/tls: BenchmarkHandshakeServer failures Jul 29, 2024
@cherrymui cherrymui mentioned this issue Jul 29, 2024
Closed
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "crypto/tls" && test ~ `BenchmarkHandshakeServer`
2024-06-18 15:33 gotip-darwin-amd64-race go@e44fa1c1 crypto/tls.BenchmarkHandshakeServer/ECDHE-X25519-ECDSA-P256/TLSv12 (log) 
=== RUN   BenchmarkHandshakeServer/ECDHE-X25519-ECDSA-P256/TLSv12
BenchmarkHandshakeServer/ECDHE-X25519-ECDSA-P256/TLSv12
    handshake_server_test.go:1346: #4: read tcp 127.0.0.1:60397->127.0.0.1:60373: use of closed network connection
        Read 0, wanted 43, got , wanted 1403030001011603030020c12291c4dd19b5f0b0d87c824f51d0bd811324fc892ffd160e6c9d180e58f3bc
    handshake_server_test.go:1349: #4: mismatch on read: got:00000000000000000000000000000000000000000000000000000000000000000000000000000000000000 want:1403030001011603030020c12291c4dd19b5f0b0d87c824f51d0bd811324fc892ffd160e6c9d180e58f3bc
--- FAIL: BenchmarkHandshakeServer/ECDHE-X25519-ECDSA-P256/TLSv12
2024-06-18 16:32 gotip-darwin-amd64-race go@4cf2b025 crypto/tls.BenchmarkHandshakeServer/ECDHE-X25519-ECDSA-P256/TLSv12-4 (log) 
--- FAIL: BenchmarkHandshakeServer/ECDHE-X25519-ECDSA-P256/TLSv12-4
2024-06-18 18:48 gotip-darwin-amd64-race go@cef0a2ec crypto/tls.BenchmarkHandshakeServer/ECDHE-P256-RSA/TLSv12 (log) 
=== RUN   BenchmarkHandshakeServer/ECDHE-P256-RSA/TLSv12
BenchmarkHandshakeServer/ECDHE-P256-RSA/TLSv12
    handshake_server_test.go:1346: #4: read tcp 127.0.0.1:49906->127.0.0.1:49896: use of closed network connection
        Read 0, wanted 43, got , wanted 1403030001011603030020d6984a2d5e5b03e16c2ff4634b31c8975d4e142adba6a63188219c02e4e81183
    handshake_server_test.go:1349: #4: mismatch on read: got:00000000000000000000000000000000000000000000000000000000000000000000000000000000000000 want:1403030001011603030020d6984a2d5e5b03e16c2ff4634b31c8975d4e142adba6a63188219c02e4e81183
--- FAIL: BenchmarkHandshakeServer/ECDHE-P256-RSA/TLSv12
2024-06-18 19:33 gotip-darwin-amd64-race go@879ace14 crypto/tls.BenchmarkHandshakeServer/ECDHE-X25519-ECDSA-P256/TLSv12-4 (log) 
--- FAIL: BenchmarkHandshakeServer/ECDHE-X25519-ECDSA-P256/TLSv12-4
2024-06-20 19:13 go1.23-darwin-amd64-race release-branch.go1.23@eba9e087 crypto/tls.BenchmarkHandshakeServer/RSA (log) 
=== RUN   BenchmarkHandshakeServer/RSA
BenchmarkHandshakeServer/RSA
    handshake_server_test.go:1346: #4: read tcp 127.0.0.1:63486->127.0.0.1:63484: use of closed network connection
        Read 0, wanted 51, got , wanted 140303000101160303002800000000000000005df832a2c7d4ac17570d9fc1962a774871f425eccda764cb20ea6acc31f0cb8b
    handshake_server_test.go:1349: #4: mismatch on read: got:000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 want:140303000101160303002800000000000000005df832a2c7d4ac17570d9fc1962a774871f425eccda764cb20ea6acc31f0cb8b
==================
WARNING: DATA RACE
Read at 0x00c0002b82c9 by goroutine 21:
  testing.(*B).run1()
      /Volumes/Work/s/w/ir/x/w/goroot/src/testing/benchmark.go:218 +0x1d8
...
  crypto/tls.benchmarkHandshakeServer()
      /Volumes/Work/s/w/ir/x/w/goroot/src/crypto/tls/handshake_server_test.go:1336 +0xa36
  crypto/tls.BenchmarkHandshakeServer.func1()
      /Volumes/Work/s/w/ir/x/w/goroot/src/crypto/tls/handshake_server_test.go:1368 +0x97
  testing.(*B).runN()
      /Volumes/Work/s/w/ir/x/w/goroot/src/testing/benchmark.go:193 +0x19c
  testing.(*B).run1.func1()
      /Volumes/Work/s/w/ir/x/w/goroot/src/testing/benchmark.go:215 +0x7b
==================
--- FAIL: BenchmarkHandshakeServer/RSA
2024-06-21 19:12 gotip-darwin-amd64-race go@fed2c11d crypto/tls.BenchmarkHandshakeServer/RSA-4 (log) 
--- FAIL: BenchmarkHandshakeServer/RSA-4
2024-06-21 19:37 gotip-darwin-amd64-race go@52ce25b4 crypto/tls.BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521/TLSv12 (log) 
=== RUN   BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521/TLSv12
BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521/TLSv12
    handshake_server_test.go:1346: #4: read tcp 127.0.0.1:55059->127.0.0.1:55019: use of closed network connection
        Read 0, wanted 43, got , wanted 1403030001011603030020e9e6b2890af8c715ba574759113fdd7443145ef9ab931663ea47246f97101255
    handshake_server_test.go:1349: #4: mismatch on read: got:00000000000000000000000000000000000000000000000000000000000000000000000000000000000000 want:1403030001011603030020e9e6b2890af8c715ba574759113fdd7443145ef9ab931663ea47246f97101255
--- FAIL: BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521/TLSv12
==================
WARNING: DATA RACE
Read at 0x00c00012ecc9 by goroutine 71:
  testing.(*B).Run()
...
  crypto/tls.benchmarkHandshakeServer()
      /Users/swarming/.swarming/w/ir/x/w/goroot/src/crypto/tls/handshake_server_test.go:1336 +0xa36
  crypto/tls.BenchmarkHandshakeServer.func5.2()
      /Users/swarming/.swarming/w/ir/x/w/goroot/src/crypto/tls/handshake_server_test.go:1410 +0x9a
  testing.(*B).runN()
      /Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/benchmark.go:193 +0x19c
  testing.(*B).run1.func1()
      /Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/benchmark.go:215 +0x7b
==================
    testing.go:1399: race detected during execution of test
2024-06-21 19:58 gotip-darwin-amd64-race go@d79c3509 crypto/tls.BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521/TLSv12 (log) 
=== RUN   BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521/TLSv12
BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521/TLSv12
    handshake_server_test.go:1346: #4: read tcp 127.0.0.1:49766->127.0.0.1:49726: use of closed network connection
        Read 0, wanted 43, got , wanted 1403030001011603030020e9e6b2890af8c715ba574759113fdd7443145ef9ab931663ea47246f97101255
    handshake_server_test.go:1349: #4: mismatch on read: got:00000000000000000000000000000000000000000000000000000000000000000000000000000000000000 want:1403030001011603030020e9e6b2890af8c715ba574759113fdd7443145ef9ab931663ea47246f97101255
--- FAIL: BenchmarkHandshakeServer/ECDHE-P521-ECDSA-P521/TLSv12

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gopherbot