Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bytes: IndexByte can return -4294967295 when memory usage is above 2^31 on js/wasm [1.21 backport] #68474

Closed
gopherbot opened this issue Jul 16, 2024 · 2 comments
Closed

bytes: IndexByte can return -4294967295 when memory usage is above 2^31 on js/wasm [1.21 backport] #68474

gopherbot opened this issue Jul 16, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases
Milestone
Go1.21.13

Comments

@gopherbot
Copy link
Contributor

@randall77 requested issue #65571 to be considered for backport to the next 1.21 minor release.

@gopherbot please open backport issues.

This bug causes {bytes,string}.Index functions to return wrong results when used with very large arguments.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jul 16, 2024
@gopherbot gopherbot mentioned this issue Jul 16, 2024
Closed
@gopherbot gopherbot added this to the Go1.21.13 milestone Jul 16, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/598995 mentions this issue: [release-branch.go1.21] internal/bytealg: extend memchr result correctly on wasm

@cherrymui cherrymui added the CherryPickApproved Used during the release process for point releases label Jul 17, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jul 17, 2024
gopherbot pushed a commit that referenced this issue Jul 17, 2024
@Zxilly @cherrymui
[release-branch.go1.21] internal/bytealg: extend memchr result correc…
d149ce8 
…tly on wasm

The mem address should be regarded as uint32.

Fixes #68474

Change-Id: Icee38d11f2d93eeca7d50b2e133159e321daeb90
GitHub-Last-Rev: c2568b1
GitHub-Pull-Request: #68400
Reviewed-on: https://go-review.googlesource.com/c/go/+/597955
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit 90c6558)
Reviewed-on: https://go-review.googlesource.com/c/go/+/598995
@gopherbot
Copy link
Contributor Author

Closed by merging CL 598995 (commit d149ce8) to release-branch.go1.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Milestone
Go1.21.13
Development

No branches or pull requests
2 participants
@gopherbot @cherrymui