proposal: slices: add AllMatch

[idsulik]

This proposal suggests adding three new methods, AllMatch, to the slices package. The method will provide developers with powerful and concise ways to perform common operations on slices, enhancing code readability and reducing the likelihood of errors.

package slices

// AllMatch checks if all elements in the slice satisfy the predicate.
func AllMatch[T any](s []T, predicate func(T) bool) bool {
    for _, v := range s {
        if !predicate(v) {
            return false
        }
    }
    return true
}

I look forward to feedback from the maintainers and the community on this proposal and I'm ready to implement it if you don't mind.

[gophun]

AnyMatch is just slices.ContainsFunc. And why a third time with SomeMatch?

[idsulik]

AnyMatch is just slices.ContainsFunc. And why a third time with SomeMatch?

yes, you're right. we can omit it or add it as an alias for the ContainerFunc(to make it intuitive, because if you see SomeMatch and AllMatch, you'll want to see AnyMatch as well)

[meyermarcel]

I don't see how a new or alias API improves readability. Adding new API defragments writing and worsens readability by having more inconsistent code. Surely writability is improved. But readability is more important in the long term.

[idsulik]

@seankhliao , could you please explain why did you change the title?

[idsulik]

Surely writability is improved. But readability is more important in the long term.

I agree with this, but I didn't get why the alias will reduce readability? As for me, it's the same as reading AnyMatch and ContainsFunc, the first one is even better, because it's intuitive and clear(the ContaintFunc sounds like "Does it contains func")

[seankhliao]

We're not going to add aliases to existing functions, plus there is an expected format for titles.

[idsulik]

We're not going to add aliases to existing functions, plus there is an expected format for titles.

thank you!
p.s. the SomeMatch is not an alias as I know, only AnyMatch

[seankhliao]

Both are aliases of ContainsFunc.

[meyermarcel]

Surely writability is improved. But readability is more important in the long term.

I agree with this, but I didn't get why the alias will reduce readability? As for me, it's the same as reading AnyMatch and ContainsFunc, the first one is even better, because it's intuitive and clear(the ContaintFunc sounds like "Does it contains func")

More possibilities for writers means more mental load for readers. An alias is not much but it adds up over the years. Look at the evolution of other languages and how many writing possibilities they have. Ultimately, writers have many opportunities on the shoulders of readers. As a reader it costs to have in mind "Ah, x is the same as y.".

[ianlancetaylor]

Rather than having specific functions in slices, these seem more appropriate for the proposal x/exp/xiters package. See, for example, #67453.