Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt: misplaced plus sign when formatting float #6856

Closed
gopherbot opened this issue Dec 1, 2013 · 7 comments
Closed

fmt: misplaced plus sign when formatting float #6856

gopherbot opened this issue Dec 1, 2013 · 7 comments
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Dec 1, 2013

by haimuiba:

What steps will reproduce the problem?

http://play.golang.org/p/yELxBFM4kF

Which compiler are you using (5g, 6g, 8g, gccgo)?

6g

Which operating system are you using?

 OS X 10.8.5

Which version are you using?  (run 'go version')

go version devel +bddf2a72f5e1 Wed Nov 27 19:32:15 2013 +1100 darwin/amd64

Please provide any additional information below.

I'd like to contribute a patch for this and will get started on this now.
@minux
Copy link
Member

@minux minux commented Dec 1, 2013

Comment 1:

Thank you for the report and https://golang.org/cl/35660043/.

Labels changed: added priority-soon, go1.3, removed priority-triage, go1.3maybe.

Status changed to Started.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Dec 2, 2013

Comment 2 by haimuiba:

> Labels: -Priority-Triage -Go1.3Maybe Priority-Soon Go1.3 
Does this means you'll look at integrating this patch for 1.3? Just curious about the
process as this is my first contribution and I'd like to provide more ; ).
Cheers,
Felix
@minux
Copy link
Member

@minux minux commented Dec 2, 2013

Comment 3:

yes. all fixes before the next code freeze will go to the next stable release (1.3).
only a few critical ones will be cherry-picked into 1.2.x minor releases.
read http://golang.org/s/releasesched for details about Go release cycles.
btw, have you signed the CLA (http://golang.org/doc/contribute.html#copyright)?
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Dec 2, 2013

Comment 4 by haimuiba:

> yes. all fixes before the next code freeze will go to the next stable release (1.3).
only a few critical ones will be cherry-picked into 1.2.x minor releases.
> read http://golang.org/s/releasesched for details about Go release cycles.
Thanks, makes sense. Will wait for somebody to review the patch and will provide an
additional patch for space padding if this one is accepted.
> btw, have you signed the CLA (http://golang.org/doc/contribute.html#copyright)?
Yes. I believe I signed it before, but I just signed it again when submitting this patch.
@rsc
Copy link
Contributor

@rsc rsc commented Dec 4, 2013

Comment 5:

Labels changed: added release-go1.3, removed go1.3.

@rsc
Copy link
Contributor

@rsc rsc commented Dec 4, 2013

Comment 6:

Labels changed: added repo-main.

@robpike
Copy link
Contributor

@robpike robpike commented Dec 12, 2013

Comment 7:

This issue was closed by revision 5ad5b7a.

Status changed to Fixed.

@rsc rsc added this to the Go1.3 milestone Apr 14, 2015
@rsc rsc removed the release-go1.3 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.