-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime:cpu2: TestRuntimeLockMetricsAndProfile/runtime.lock/sample-1 failures #68781
Comments
Found new dashboard test flakes for:
2024-08-07 16:08 gotip-linux-arm go@aba16d17 runtime:cpu2.TestRuntimeLockMetricsAndProfile/runtime.lock/sample-1 (log)
|
Tentatively closing this as a duplicate of #68453. |
@mauri870 it looks like gopherbot is splitting the reports based on "cpu2" or "cpu4". An update to the watchflakes line on the other issue would probably keep the bot from reopening this on the next "cpu2" failure. (Though, no harm in waiting until then.) But I also intend to close both of the issues when I merge the change I described in #68453 (comment) . Maybe later today. |
Change https://go.dev/cl/604355 mentions this issue: |
The block and mutex profiles have slightly different behaviors when a sampled event has a negative (or zero) duration. The block profile enforces a minimum duration for each event of "1" in the cputicks unit. It does so by clamping the duration to 1 if it was originally reported as being smaller. The mutex profile for app-level contention enforces a minimum duration of 0 in a similar way: by reporting any negative values as 0 instead. The mutex profile for runtime-internal contention had a different behavior: to enforce a minimum event duration of "1" by dropping any non-conforming samples. Stop dropping samples, and use the same minimum (0) that's in place for the other mutex profile events. Fixes #64253 Fixes #68453 Fixes #68781 Change-Id: I4c5d23a2675501226eef5b9bc1ada2efc1a55b9e Reviewed-on: https://go-review.googlesource.com/c/go/+/604355 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com> Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org> Auto-Submit: Rhys Hiltner <rhys.hiltner@gmail.com>
Found new dashboard test flakes for:
2024-08-30 17:51 gotip-linux-ppc64_power10 go@4f327f27 runtime:cpu2.TestRuntimeLockMetricsAndProfile/runtime.lock/sample-1 (log)
|
@rhysh could you take a look at the new failure? Is this happening again? Thanks. |
Yes, will do. |
Issue created automatically to collect these failures.
Example (log):
— watchflakes
The text was updated successfully, but these errors were encountered: