Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: remove -gorepo flag #68789

Open
matloob opened this issue Aug 8, 2024 · 2 comments
Open

x/pkgsite: remove -gorepo flag #68789

matloob opened this issue Aug 8, 2024 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite

Comments

@matloob
Copy link
Contributor

matloob commented Aug 8, 2024

There are two ways of setting the goroot to use for stdlib packages: one is the -gorepo flag, and the other is the GOROOT of the go command in PATH. Most of our tools use the GOROOT of the go command, so pkgsite should probably standardize on doing that.

@gabyhelp
Copy link

gabyhelp commented Aug 8, 2024

Related Issues and Documentation

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 12, 2024
@cagedmantis cagedmantis changed the title cmd/pkgsite: remove -gorepo flag x/pkgsite: remove -gorepo flag Aug 12, 2024
@gopherbot gopherbot added this to the Unreleased milestone Aug 12, 2024
@cagedmantis
Copy link
Contributor

cc @golang/pkgsite

@hyangah hyangah modified the milestones: Unreleased, pkgsite/backlog Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Development

No branches or pull requests

5 participants