-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/sys/windows: TestAddRemoveDllDirectory failures #69029
Comments
Found new dashboard test flakes for:
2024-08-22 21:00 x_sys-go1.22-windows-arm64 sys@a8c5219b release-branch.go1.22@e87be983 x/sys/windows.TestAddRemoveDllDirectory [ABORT] (log)
|
We are seeing similar reports of Windows
Again, the code works perfectly fine when compiled using Go 1.22.X |
Not sure it is the same issue @leaanthony. This trace, extracted from the provided logs, seems suspisious: This regression you are seeing when using go1.23 is probably related to CL 563315, which optimized the I'm inclined to say that this is not a go1.23 regression, although it can break @golang/windows @golang/release |
I really appreciate the time you took to respond 🙏 I've looked at replacing syscall with syscallN and indeed it does seem to have addressed the issue. I did not know about that change and didn't find it in the release notes so I appreciate the link. Thank you 🙏 |
Provisionally assigned to @qmuntal, not clear if this is a problem at tip or not. |
Found new dashboard test flakes for:
2024-09-04 13:19 x_sys-go1.23-windows-arm64 sys@a43b625d release-branch.go1.23@80ff7cd3 x/sys/windows.TestAddRemoveDllDirectory [ABORT] (log)
|
Previously we manually imported system windows DDLs and made direct syscall. But golang exposes syscall wrappers with sys/windows package. It seems, that direct syscall was broken at 1.23 golang release. It was `GetDiskFreeSpace` syscall in our case. This commit replaces all manual syscalls with wrappers Related issue: #6973 Related golang issue: golang/go#69029 Signed-off-by: f41gh7 <nik@victoriametrics.com>
Previously we manually imported system windows DDLs and made direct syscall. But golang exposes syscall wrappers with sys/windows package. It seems, that direct syscall was broken at 1.23 golang release. It was `GetDiskFreeSpace` syscall in our case. This commit replaces all manual syscalls with wrappers Related issue: #6973 Related golang issue: golang/go#69029 Signed-off-by: f41gh7 <nik@victoriametrics.com>
Found new dashboard test flakes for:
2024-11-12 17:28 x_sys-gotip-windows-arm64 sys@a13946c6 go@ab554650 x/sys/windows.TestAddRemoveDllDirectory [ABORT] (log)
|
Found new dashboard test flakes for:
2024-12-26 15:58 x_sys-go1.23-windows-arm64 sys@680bd24a release-branch.go1.23@1576793c x/sys/windows.TestAddRemoveDllDirectory [ABORT] (log)
|
Issue created automatically to collect these failures.
Example (log):
— watchflakes
The text was updated successfully, but these errors were encountered: