Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: package removal request for github.com/ipfs/go-ipfs-cmds v1 and v2 #69093

Closed
lidel opened this issue Aug 27, 2024 · 4 comments
Closed
Labels
Milestone

Comments

@lidel
Copy link

lidel commented Aug 27, 2024

github.com/ipfs/go-ipfs-cmds has three retracted versions (go.mod):

  • v1.0.22
  • v2.0.1+incompatible
  • v2.0.2+incompatible

The package is still at v0.x.x and we were unable to retract v1 and v2 versions correctly (created before go.mod existed), which leads to ecosystem issues (ipfs/go-ipfs-cmds#254 (comment)).

Is it possible to manually remove these three versions from pkgsite and mark v0 one as the latest?
(We don't have v1 and v2 tags in git repository)

Instead of

$ GOPROXY=https://proxy.golang.org GO111MODULE=on go list -m -versions github.com/ipfs/go-ipfs-cmds
github.com/ipfs/go-ipfs-cmds v0.0.1 v0.0.2 v0.0.3 v0.0.4 v0.0.5 v0.0.6 v0.0.7 v0.0.8 v0.0.9 v0.0.10 v0.1.0 v0.1.1 v0.1.2 v0.1.3 v0.1.4 v0.2.0 v0.2.1 v0.2.2 v0.2.9 v0.3.0 v0.4.0 v0.5.0 v0.6.0 v0.7.0 v0.8.0 v0.8.1 v0.8.2 v0.9.0 v0.10.0 v0.10.1 v0.10.2 v0.11.0 v0.12.0 v0.13.0 v1.0.22 v2.0.1+incompatible

We want:

$ GOPROXY=direct GO111MODULE=on go list -m -versions github.com/ipfs/go-ipfs-cmds
github.com/ipfs/go-ipfs-cmds v0.0.1 v0.0.2 v0.0.3 v0.0.4 v0.0.5 v0.0.6 v0.0.7 v0.0.8 v0.0.9 v0.0.10 v0.1.0 v0.1.1 v0.1.2 v0.1.3 v0.1.4 v0.2.0 v0.2.1 v0.2.2 v0.2.9 v0.3.0 v0.4.0 v0.5.0 v0.6.0 v0.7.0 v0.8.0 v0.8.1 v0.8.2 v0.9.0 v0.10.0 v0.10.1 v0.10.2 v0.11.0 v0.12.0 v0.13.0
@seankhliao
Copy link
Member

removal only hides the documentation, it does not affect the versions the go command sees.

@seankhliao
Copy link
Member

retractions do work for v2+incompatible, they just have to be on the highest v1 tag.

pkgsite can only hide entire modules, as you still want to use the other versions, i don't think a removal request is right.

@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Aug 27, 2024
@lidel
Copy link
Author

lidel commented Aug 28, 2024

@seankhliao thank you, but we did not see retractions of v2+incompatible to be working. Would appreciate some elaboration on what works and what does not, or some hint what we are doing wrong.

We DO have retractions in v0.13.0 (go.mod here) but they are not applied when GOPROXY=https://proxy.golang.org is used. Same with https://pkg.go.dev/github.com/ipfs/go-ipfs-cmds:

image

Are you saying that v0 updates are ignored by https://proxy.golang.org and the only way to fix this is if we publish v1?

Why retraction of v2+incompatible would work for v1 and not for v0? Is this limitation of proxy.golang.org or go tooling itself?

@seankhliao
Copy link
Member

your retraction has to be at v1.0.23 or above (highest version regardless of retraction), the retraction can include itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants