Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: double close pidfd if caller uses pidfd updated by os.StartProcess [1.23 backport] #69119

Closed
gopherbot opened this issue Aug 28, 2024 · 2 comments
Closed

os: double close pidfd if caller uses pidfd updated by os.StartProcess [1.23 backport] #69119

gopherbot opened this issue Aug 28, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.23.2

Comments

@gopherbot
Copy link
Contributor

@prattmic requested issue #68984 to be considered for backport to the next 1.23 minor release.

@gopherbot Please backport to 1.23. This is a regression in os.StartProcess for programs already using pidfds.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 28, 2024
@gopherbot gopherbot mentioned this issue Aug 28, 2024
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 28, 2024
@gopherbot gopherbot added this to the Go1.23.1 milestone Aug 28, 2024
@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Sep 4, 2024
@gopherbot gopherbot modified the milestones: Go1.23.1, Go1.23.2 Sep 5, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/611415 mentions this issue: [release-branch.go1.23] os: dup pidfd if caller sets PidFD manually

gopherbot pushed a commit that referenced this issue Sep 6, 2024
@fuweid @gopherbot
[release-branch.go1.23] os: dup pidfd if caller sets PidFD manually
e6598e7 
For #68984.
Fixes #69119.

Change-Id: I16d25777cb38a337cd4204a8147eaf866c3df9e1
Reviewed-on: https://go-review.googlesource.com/c/go/+/607695
Reviewed-by: Kirill Kolyshkin <kolyshkin@gmail.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Commit-Queue: Ian Lance Taylor <iant@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Auto-Submit: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 239666c)
Reviewed-on: https://go-review.googlesource.com/c/go/+/611415
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Contributor Author

Closed by merging CL 611415 (commit e6598e7) to release-branch.go1.23.

@mknyszek mknyszek changed the title os,syscall: double close pidfd if caller uses pidfd updated by os.StartProcess [1.23 backport] os: double close pidfd if caller uses pidfd updated by os.StartProcess [1.23 backport] Oct 1, 2024
@austinvazquez austinvazquez mentioned this issue Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.23.2
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot