Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: mapassign_fast64ptr crashes in malloc #69151

Open
adonovan opened this issue Aug 29, 2024 · 4 comments
Open

runtime: mapassign_fast64ptr crashes in malloc #69151

adonovan opened this issue Aug 29, 2024 · 4 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@adonovan
Copy link
Member

This stack cysh5A was reported by telemetry:

crash/crash
runtime.systemstack_switch:+4
runtime.persistentalloc:+2
runtime.newBucket:+11
runtime.stkbucket:+53
runtime.mProf_Malloc:+13
runtime.profilealloc:+6
runtime.mallocgc:+270
runtime.newarray:+8
runtime.makeBucketArray:+18
runtime.hashGrow:+10
runtime.mapassign_fast64ptr:+64
go/types.(*Checker).recordSelection:+4
go/types.(*Checker).selector:+232
go/types.(*Checker).exprInternal:+308
go/types.(*Checker).rawExpr:+10
go/types.(*Checker).exprOrType:+1
golang.org/x/tools/gopls@v0.16.1 go1.23.0 windows/amd64 neovim (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan adonovan added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. gopls/telemetry-wins labels Aug 29, 2024
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 29, 2024
@adonovan
Copy link
Member Author

@prattmic @mknyszek

@prattmic
Copy link
Member

It's unfortunate that this only captures the stack from systemstack_switch.

My guess is that this is most likely "runtime: cannot allocate memory" from https://cs.opensource.google/go/go/+/master:src/runtime/malloc.go;l=1609;drc=54fe0fd43fcf8609666c16ae6d15ed92873b1564

@cherrymui
Copy link
Member

If it just runs out of memory, I'm not sure if there is anything particular we can do...

@cherrymui
Copy link
Member

@randall77 mentioned that if it is the profiler fail to allocate memory, we can ignore it and just not profile, but it will probably fail soon in some other allocations...

It would be nice if we can get any information about the memory, but that would be hard for telemetry...

@prattmic prattmic added this to the Backlog milestone Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Development

No branches or pull requests

4 participants