testing: TestChdir can fail on Windows when GOROOT and TMPDIR are on different drives

[qiulaidongfeng]

Go version

go version devel go1.24-9e8ea567c8 Wed Aug 28 21:03:29 2024 +0000 windows/amd64

Output of go env in your module/workspace:

set GO111MODULE=auto
set GOARCH=amd64
set GOBIN=
set GOCACHE=D:\file\go-build
set GOENV=C:\Users\26454\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=D:\file\gofile\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=D:\file\gofile
set GOPRIVATE=
set GOPROXY=https://goproxy.cn,direct
set GOROOT=D:\file\gofile\gogit\go1
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLCHAIN=local
set GOTOOLDIR=D:\file\gofile\gogit\go1\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=devel go1.24-9e8ea567c8 Wed Aug 28 21:03:29 2024 +0000
set GODEBUG=
set GOTELEMETRY=on
set GOTELEMETRYDIR=C:\Users\26454\AppData\Roaming\go\telemetry
set GCCGO=gccgo
set GOAMD64=v3
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=D:\file\gofile\gogit\go1\src\go.mod
set GOWORK=
set CGO_CFLAGS=-O2 -g
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-O2 -g
set CGO_FFLAGS=-O2 -g
set CGO_LDFLAGS=-O2 -g
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=C:\Users\26454\AppData\Local\Temp\go-build3099250739=/tmp/go-build -gno-record-gcc-switches

What did you do?

git clone https://github.com/golang/go.git
set GOROOT is git clone dir
cd src
all

What did you see happen?

test pass.

What did you expect to see?

--- FAIL: TestChdir (0.00s)
testing_test.go:303: Rel: can't make C:\Users\26454\AppData\Local\Temp\TestChdir3453836523\001 relative to D:\file\gofile\gogit\go1\src\testing
FAIL
FAIL testing 7.715s
FAIL

[gabyhelp]

Related Issues and Documentation

• os: TestFileChdir fail when GOROOT is a symbolic link #64281 (closed)
• cmd/go: TestScript/mod_convert_git fails if GOROOT is in a subdirectory of a git repository #34191 (closed)
• go test cache check wrong opened file when testing if user do `os.Chdir` #47305 (closed)
• `go test` breaks when working directory is outside of `go.mod` hierarchy even though argument path is inside module directory #47363 (closed)
• cmd/go: TestExecutableGOROOT fails on windows #20336 (closed)
• cmd/go: TestScript expects go.env to contain GOTOOLCHAIN=auto #60685 (closed)
• error gopath #66295 (closed)
• cmd/go: go test cannot find module path in module root directory #26722 (closed)
• cmd/go: tests fail when GOROOT is stale #48698 (closed)
• runtime/debug: TestStack fail #65506 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Change https://go.dev/cl/609304 mentions this issue: testing: skip TestChdir when GOROOT is git clone dir

[seankhliao]

I don't see why this relates to GOROOT?
The check is for getting a relative location of a tempdir to the current working directory. It would fail on windows if they're on different volumes (since windows doesn't have a single root).

[qiulaidongfeng]

cc @kolyshkin @dmitshur because they have CL submitted related to this test.