Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/race:race: TestOutput failures #69257

Open
gopherbot opened this issue Sep 4, 2024 · 6 comments
Open

runtime/race:race: TestOutput failures #69257

gopherbot opened this issue Sep 4, 2024 · 6 comments
Assignees
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "runtime/race:race" && test == "TestOutput"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestOutput
    output_test.go:83: failed test case wrappersym, expect:
        ==================
        WARNING: DATA RACE
        Write at 0x[0-9,a-f]+ by goroutine [0-9]:
          main\.T\.f\(\)
              .*/main.go:15 \+0x[0-9,a-f]+
          main\.\(\*T\)\.f\(\)
              <autogenerated>:1 \+0x[0-9,a-f]+
          main\.main\.gowrap1\(\)
...
          main.main.gowrap1()
              /home/swarming/.swarming/w/ir/x/t/TestOutput26943986/013/main.go:9 +0x68
        
        Goroutine 6 (finished) created at:
          main.main()
              /home/swarming/.swarming/w/ir/x/t/TestOutput26943986/013/main.go:9 +0x98
        ==================
        Found 1 data race(s)
        exit status 66
--- FAIL: TestOutput (8.52s)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 4, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "runtime/race:race" && test == "TestOutput"
2024-09-04 04:56 gotip-linux-ppc64le_power8 go@1b5ae451 runtime/race:race.TestOutput (log)
=== RUN   TestOutput
    output_test.go:83: failed test case wrappersym, expect:
        ==================
        WARNING: DATA RACE
        Write at 0x[0-9,a-f]+ by goroutine [0-9]:
          main\.T\.f\(\)
              .*/main.go:15 \+0x[0-9,a-f]+
          main\.\(\*T\)\.f\(\)
              <autogenerated>:1 \+0x[0-9,a-f]+
          main\.main\.gowrap1\(\)
...
          main.main.gowrap1()
              /home/swarming/.swarming/w/ir/x/t/TestOutput26943986/013/main.go:9 +0x68
        
        Goroutine 6 (finished) created at:
          main.main()
              /home/swarming/.swarming/w/ir/x/t/TestOutput26943986/013/main.go:9 +0x98
        ==================
        Found 1 data race(s)
        exit status 66
--- FAIL: TestOutput (8.52s)

watchflakes

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Sep 4, 2024
@prattmic
Copy link
Member

Looks like the regexp expects the line 9 case first and line 10 second, but got it in the opposite order. Maybe the test is fragile? Can it actually control the order of the writes?

@prattmic prattmic added this to the Backlog milestone Sep 11, 2024
@ianlancetaylor
Copy link
Member

The failing test was added by @aclements in May, 2023 in https://go.dev/cl/497235. For purposes of the issue (#60245) I suspect we can simply the regexp to just look for the wrapper symbol. Or, we could do what some of the other tests do and add a time.Sleep to make the expected ordering even more likely than it already is.

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "runtime/race:race" && test == "TestOutput"
2024-11-18 18:43 gotip-linux-amd64-boringcrypto go@5a0f2a7a runtime/race:race.TestOutput (log)
=== RUN   TestOutput
    output_test.go:83: failed test case wrappersym, expect:
        ==================
        WARNING: DATA RACE
        Write at 0x[0-9,a-f]+ by goroutine [0-9]:
          main\.T\.f\(\)
              .*/main.go:15 \+0x[0-9,a-f]+
          main\.\(\*T\)\.f\(\)
              <autogenerated>:1 \+0x[0-9,a-f]+
          main\.main\.gowrap1\(\)
...
          main.main.gowrap1()
              /home/swarming/.swarming/w/ir/x/t/TestOutput1629240431/013/main.go:9 +0x3a
        
        Goroutine 6 (finished) created at:
          main.main()
              /home/swarming/.swarming/w/ir/x/t/TestOutput1629240431/013/main.go:9 +0x8d
        ==================
        Found 1 data race(s)
        exit status 66
--- FAIL: TestOutput (9.24s)

watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "runtime/race:race" && test == "TestOutput"
2024-11-19 22:30 gotip-linux-amd64 go@8c2a04f1 runtime/race:race.TestOutput (log)
=== RUN   TestOutput
    output_test.go:83: failed test case wrappersym, expect:
        ==================
        WARNING: DATA RACE
        Write at 0x[0-9,a-f]+ by goroutine [0-9]:
          main\.T\.f\(\)
              .*/main.go:15 \+0x[0-9,a-f]+
          main\.\(\*T\)\.f\(\)
              <autogenerated>:1 \+0x[0-9,a-f]+
          main\.main\.gowrap1\(\)
...
          main.main.gowrap1()
              /home/swarming/.swarming/w/ir/x/t/TestOutput2470865229/013/main.go:9 +0x3a
        
        Goroutine 6 (finished) created at:
          main.main()
              /home/swarming/.swarming/w/ir/x/t/TestOutput2470865229/013/main.go:9 +0x8d
        ==================
        Found 1 data race(s)
        exit status 66
--- FAIL: TestOutput (11.87s)

watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "runtime/race:race" && test == "TestOutput"
2025-01-03 18:12 go1.24-linux-ppc64le_power8 release-branch.go1.24@eb0c2b2f runtime/race:race.TestOutput (log)
=== RUN   TestOutput
    output_test.go:83: failed test case wrappersym, expect:
        ==================
        WARNING: DATA RACE
        Write at 0x[0-9,a-f]+ by goroutine [0-9]:
          main\.T\.f\(\)
              .*/main.go:15 \+0x[0-9,a-f]+
          main\.\(\*T\)\.f\(\)
              <autogenerated>:1 \+0x[0-9,a-f]+
          main\.main\.gowrap1\(\)
...
          main.main.gowrap1()
              /home/swarming/.swarming/w/ir/x/t/TestOutput1968080768/013/main.go:9 +0x68
        
        Goroutine 6 (finished) created at:
          main.main()
              /home/swarming/.swarming/w/ir/x/t/TestOutput1968080768/013/main.go:9 +0x98
        ==================
        Found 1 data race(s)
        exit status 66
--- FAIL: TestOutput (8.13s)

watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: No status
Development

No branches or pull requests

4 participants