Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/telemetry: download the upload config lazily #69262

Open
findleyr opened this issue Sep 4, 2024 · 1 comment
Open

x/telemetry: download the upload config lazily #69262

findleyr opened this issue Sep 4, 2024 · 1 comment
Assignees
Labels
telemetry x/telemetry issues
Milestone

Comments

@findleyr
Copy link
Contributor

findleyr commented Sep 4, 2024

This is a follow up to #68946. To fix that issue for go 1.23.1, we did the absolutely narrowest fix to suppress the telemetry config download if the telemetry mode is not "on".

However, we should also make the download lazy, so that we download the config once a week when there is actual work to upload, rather than once a day when the upload process runs.

We could also consider back-porting this fix to 1.23.2, as I think it will be a safe change.

@findleyr findleyr self-assigned this Sep 4, 2024
@gopherbot gopherbot added the telemetry x/telemetry issues label Sep 4, 2024
@gopherbot gopherbot added this to the Unreleased milestone Sep 4, 2024
@gabyhelp
Copy link

gabyhelp commented Sep 4, 2024

Related Issues and Documentation

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@findleyr findleyr modified the milestones: Unreleased, Go1.24 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
telemetry x/telemetry issues
Projects
None yet
Development

No branches or pull requests

3 participants