-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime,time: timer.Stop returns false even when no value is read from the channel [1.23 backport] #69333
Labels
CherryPickApproved
Used during the release process for point releases
compiler/runtime
Issues related to the Go compiler and/or runtime.
Milestone
Comments
gopherbot
added
the
CherryPickCandidate
Used during the release process for point releases
label
Sep 7, 2024
gopherbot
added
the
compiler/runtime
Issues related to the Go compiler and/or runtime.
label
Sep 7, 2024
cagedmantis
added
the
CherryPickApproved
Used during the release process for point releases
label
Sep 18, 2024
This is approved as it is a bug without a workaround. |
gopherbot
removed
the
CherryPickCandidate
Used during the release process for point releases
label
Sep 18, 2024
Change https://go.dev/cl/616096 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Sep 27, 2024
…er, return correct result The timer code is careful to ensure that if stop/reset is called while a timer is being run, we cancel the run. However, the code failed to ensure that in that case stop/reset returned true, meaning that the timer had been stopped. In the racing case stop/reset could see that t.when had been set to zero, and return false, even though the timer had not and never would fire. Fix this by tracking whether a timer run is in progress, and using that to reliably detect that the run was cancelled, meaning that stop/reset should return true. For #69312 Fixes #69333 Change-Id: I78e870063eb96650638f12c056e32c931417c84a Reviewed-on: https://go-review.googlesource.com/c/go/+/611496 Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Ian Lance Taylor <iant@golang.org> (cherry picked from commit 2ebaff4) Reviewed-on: https://go-review.googlesource.com/c/go/+/616096 Reviewed-by: Ian Lance Taylor <iant@google.com> Commit-Queue: Ian Lance Taylor <iant@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com>
mknyszek
changed the title
runtime: timer.Stop returns false even when no value is read from the channel [1.23 backport]
runtime,time: timer.Stop returns false even when no value is read from the channel [1.23 backport]
Oct 1, 2024
Change https://go.dev/cl/617596 mentions this issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CherryPickApproved
Used during the release process for point releases
compiler/runtime
Issues related to the Go compiler and/or runtime.
@ianlancetaylor requested issue #69312 to be considered for backport to the next 1.23 minor release.
The text was updated successfully, but these errors were encountered: