Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: resolve comment links to unimported package-qualified symbols such as [net/http.Request] #69379

Open
findleyr opened this issue Sep 10, 2024 · 4 comments
Assignees
Labels
FeatureRequest gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Member

Reported by @mvdan in slack: while the doc comment spec allows for qualified doc links such as [net/http.Request], it looks like the support for these links added in #64648 does not implement this support.

I've run into this as well; we should add this support.

@findleyr findleyr added this to the gopls/v0.17.0 milestone Sep 10, 2024
@findleyr findleyr self-assigned this Sep 10, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 10, 2024
@gabyhelp
Copy link

Related Issues and Documentation

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@findleyr
Copy link
Member Author

Closing as a dupe of #61677.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2024
@findleyr
Copy link
Member Author

Err, it's not an exact dupe, so I'll track this work separately.

@findleyr findleyr reopened this Sep 10, 2024
@findleyr findleyr modified the milestones: gopls/v0.17.0, gopls/v0.18.0 Oct 23, 2024
@mvdan
Copy link
Member

mvdan commented Oct 30, 2024

I ran into this again today. I'd be happy to assist in testing or code review when a fix does come up.

FWIW I see similar issues with e.g. [error] or [error.Error], which do not work as links for https://pkg.go.dev/builtin#error. The builtin package is a bit special and perhaps needs extra code to be handled correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

4 participants