Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/playground: simplify development and testing #69403

Open
findleyr opened this issue Sep 11, 2024 · 1 comment
Open

x/playground: simplify development and testing #69403

findleyr opened this issue Sep 11, 2024 · 1 comment
Labels
Friction Nuisances that make good candidates for our "friction" fix-it weeks NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@findleyr
Copy link
Member

The playground development setup requires Docker, and as a result there is relatively little test coverage using go test (and therefore very little coverage in our default CI). CL 612456 is an example of a small change where a test would have been nice, but was not feasible due to friction and time constraints. Proof: in https://go.dev/cl/549015, I had actually started this fix for a related issue, and stalled because it was a low priority and I felt a test was warranted.

As a de-facto-but-superficial maintainer of the playground, I think this friction is holding back playground fixes and other improvements. From first principles, we should be able run the playground without Docker, and in doing so should be able to write end-to-end tests.

I think this is a good candidate for a friction fixit week.

@findleyr findleyr added the Friction Nuisances that make good candidates for our "friction" fix-it weeks label Sep 11, 2024
@gopherbot gopherbot added this to the Unreleased milestone Sep 11, 2024
@dmitshur
Copy link
Contributor

Tracking issue #66002 is related.

@timothy-king timothy-king added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Friction Nuisances that make good candidates for our "friction" fix-it weeks NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

4 participants