Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: show header on mobile devices #69494

Open
loveboat opened this issue Sep 16, 2024 · 4 comments
Open

x/website: show header on mobile devices #69494

loveboat opened this issue Sep 16, 2024 · 4 comments
Assignees
Labels
NeedsFix The path to resolution is known, but the work has not been done. website

Comments

@loveboat
Copy link

What is the URL of the page with the issue?

https://go.dev/tour

and all subsequent /tour pages

Description

On desktop the header h2 is clearly visible on the tour screens:

image

However, on mobile devices, the header is obscured due to incorrect padding:

image

As viewed here via devtools:

image

What did you see happen?

The header was hidden when viewed on a mobile device

What did you expect to see?

The header displayed on mobile as it is on desktop

@gopherbot gopherbot added this to the Unreleased milestone Sep 16, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/613675 mentions this issue: tour: show header on mobile devices

@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 17, 2024
@cagedmantis
Copy link
Contributor

cc @golang/tools-team

@hyangah hyangah added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 3, 2024
@hyangah hyangah modified the milestones: Unreleased, website/backlog Oct 3, 2024
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 3, 2024
@hyangah hyangah self-assigned this Oct 3, 2024
@hyangah
Copy link
Contributor

hyangah commented Oct 3, 2024

Thanks for the CL @loveboat. I assigned myself to remind myself to review/test the change.

@loveboat
Copy link
Author

No worries @hyangah - hopefully this (rather straightforward) change makes it in soon!

Let me know if you need me to do anything for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix The path to resolution is known, but the work has not been done. website
Projects
None yet
Development

No branches or pull requests

4 participants