x/tools: tag and delete refactor/rename, refactor/importgraph, go/buildutil, cmd/gomvpkg

[adonovan]

While implementing this proposal:

• x/tools/cmd/gorename: tag and delete it #69360

I immediately realized that most of the logic is not in the cmd package but in the refactor/rename package, which has never worked with Go modules. Similarly, refactor/importgraph and go/buildutil have the same limitation. And cmd/gomvpkg is in a similar state to the (now deleted) cmd/gorename.

I propose to tag and delete all of them following a similar process.

(FWIW, the only seemingly valuable part of go/buildutil is TagsFlag, which doesn't actually work in conjunction with go/packages; one must use the syntax gopackages -buildflag=-tags=... patterns....)

[gabyhelp]

Related Issues and Documentation

• x/tools/cmd/{gomvpkg, gorename}: change scope is too large #10917 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Change https://go.dev/cl/614895 mentions this issue: cmd/{callgraph,ssadump}, gopackages: make -tags flags work

[rsc]

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group