-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: rename package decl fails in CLI #69582
Comments
@adonovan rename unit test just run this function. |
I think this requires more investigation. If it is failing on emacs, then the fix cannot just be in the command line. My guess is that emacs does not support the 'rename' resource operation kind: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#resourceOperationKind And my guess is that our CLI client does not either. Renaming packages works on coc.nvim, but doesn't quite work correctly: I always get warnings when saving about overwriting the file on disk. That may be a client problem. |
Ah, it looks like the command line client does purport to support rename operations, so the associated fix may be right. We should check whether emacs supports them. |
I've split the documentation and eglot issues out:
This issue is now just about the CLI. |
Change https://go.dev/cl/615375 mentions this issue: |
The rename package feature appears not to be working either in the CLI nor in Emacs+eglot:
It is working from VS Code though.
Also, it is undocumented. I've split this out as #69624.
The text was updated successfully, but these errors were encountered: