Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: os.checkPidfd() crashes with SIGSYS [1.23 backport] #69640

Closed
gopherbot opened this issue Sep 26, 2024 · 2 comments
Closed

os: os.checkPidfd() crashes with SIGSYS [1.23 backport] #69640

gopherbot opened this issue Sep 26, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases
Milestone
Go1.23.3

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #69065 to be considered for backport to the next 1.23 minor release.

@gopherbot Please open a backport to 1.23.

This issue causes Go programs to be unable to exec other programs on earlier versions of Android. There is no workaround.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 26, 2024
@gopherbot gopherbot mentioned this issue Sep 26, 2024
Closed
@gopherbot gopherbot added this to the Go1.23.2 milestone Sep 26, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/616077 mentions this issue: [release-branch.go1.23] os: ignore SIGSYS in checkPidfd

@gopherbot gopherbot modified the milestones: Go1.23.2, Go1.23.3 Oct 1, 2024
@mknyszek mknyszek added the CherryPickApproved Used during the release process for point releases label Oct 2, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Oct 2, 2024
@mknyszek mknyszek added CherryPickApproved Used during the release process for point releases and removed CherryPickApproved Used during the release process for point releases labels Oct 2, 2024
gopherbot pushed a commit that referenced this issue Oct 2, 2024
@cions @gopherbot
[release-branch.go1.23] os: ignore SIGSYS in checkPidfd
9563300 
In Android version 11 and earlier, pidfd-related system calls
are not allowed by the seccomp policy, which causes crashes due
to SIGSYS signals.

For #69065
Fixes #69640

Change-Id: Ib29631639a5cf221ac11b4d82390cb79436b8657
GitHub-Last-Rev: aad6b3b
GitHub-Pull-Request: #69543
Reviewed-on: https://go-review.googlesource.com/c/go/+/614277
Auto-Submit: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
(cherry picked from commit a3a05ed)
Reviewed-on: https://go-review.googlesource.com/c/go/+/616077
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Kirill Kolyshkin <kolyshkin@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
@gopherbot
Copy link
Contributor Author

Closed by merging CL 616077 (commit 9563300) to release-branch.go1.23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Milestone
Go1.23.3
Development

No branches or pull requests
2 participants
@mknyszek @gopherbot