Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: TestGdbAutotmpTypes failures [1.23 backport] #69746

Closed
gopherbot opened this issue Oct 2, 2024 · 2 comments
Closed

runtime: TestGdbAutotmpTypes failures [1.23 backport] #69746

gopherbot opened this issue Oct 2, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.23.3

Comments

@gopherbot
Copy link
Contributor

@prattmic requested issue #69527 to be considered for backport to the next 1.23 minor release.

@gopherbot Please backport to 1.23 and 1.22. This is a test-only fix due to a change on the builders (new version of GDB). Hence release branches are also flaking.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 2, 2024
@gopherbot gopherbot mentioned this issue Oct 2, 2024
Open
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Oct 2, 2024
@gopherbot gopherbot added this to the Go1.23.3 milestone Oct 2, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/617455 mentions this issue: [release-branch.go1.23] runtime: fix TestGdbAutotmpTypes on gdb version 15

@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Oct 2, 2024
@mknyszek mknyszek added the CherryPickApproved Used during the release process for point releases label Oct 2, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Oct 2, 2024
gopherbot pushed a commit that referenced this issue Oct 2, 2024
@shuLhan @gopherbot
[release-branch.go1.23] runtime: fix TestGdbAutotmpTypes on gdb versi…
f8080ed 
…on 15

On Arch Linux with gdb version 15.1, the test for TestGdbAutotmpTypes print
the following output,

----
~/src/go/src/runtime
$ go test -run=TestGdbAutotmpTypes -v
=== RUN   TestGdbAutotmpTypes
=== PAUSE TestGdbAutotmpTypes
=== CONT  TestGdbAutotmpTypes
    runtime-gdb_test.go:78: gdb version 15.1
    runtime-gdb_test.go:570: gdb output:
        Loading Go Runtime support.
        Target 'exec' cannot support this command.
        Breakpoint 1 at 0x46e416: file /tmp/TestGdbAutotmpTypes750485513/001/main.go, line 8.

        This GDB supports auto-downloading debuginfo from the following URLs:
          <https://debuginfod.archlinux.org>
        Enable debuginfod for this session? (y or [n]) [answered N; input not from terminal]
        Debuginfod has been disabled.
        To make this setting permanent, add 'set debuginfod enabled off' to .gdbinit.
        [New LWP 355373]
        [New LWP 355374]
        [New LWP 355375]
        [New LWP 355376]

        Thread 1 "a.exe" hit Breakpoint 1, main.main () at /tmp/TestGdbAutotmpTypes750485513/001/main.go:8
        8       func main() {
        9               var iface interface{} = map[string]astruct{}
        All types matching regular expression "astruct":

        File runtime:
                []main.astruct
                bucket<string,main.astruct>
                hash<string,main.astruct>
                main.astruct
                typedef hash<string,main.astruct> * map[string]main.astruct;
                typedef noalg.[8]main.astruct noalg.[8]main.astruct;
                noalg.map.bucket[string]main.astruct
    runtime-gdb_test.go:587: could not find []main.astruct; in 'info typrs astruct' output
!!! FAIL
exit status 1
FAIL    runtime 0.273s
$
----

In the back trace for "File runtime", each output lines does not end with
";" anymore, while in test we check the string with it.

While at it, print the expected string with "%q" instead of "%s" for
better error message.

For #67089
Fixes #69746

Change-Id: If6019ee68c0d8e495c920f98568741462c7d0fd0
Reviewed-on: https://go-review.googlesource.com/c/go/+/598135
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Meng Zhuo <mengzhuo1203@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
(cherry picked from commit ff695ca)
Reviewed-on: https://go-review.googlesource.com/c/go/+/617455
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
@gopherbot
Copy link
Contributor Author

Closed by merging CL 617455 (commit f8080ed) to release-branch.go1.23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.23.3
Development

No branches or pull requests
3 participants
@mknyszek @dmitshur @gopherbot