Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: TestCopyFS failures #69788

Closed
gopherbot opened this issue Oct 4, 2024 · 14 comments
Closed

os: TestCopyFS failures #69788

gopherbot opened this issue Oct 4, 2024 · 14 comments
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.24

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "os" && test == "TestCopyFS"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestCopyFS
=== PAUSE TestCopyFS
=== CONT  TestCopyFS
    os_test.go:3321: comparing two directories: file "a" rw mode is -rw-------, want -rw-r--r--
--- FAIL: TestCopyFS (0.60s)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 4, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "os" && test == "TestCopyFS"
2024-10-04 18:07 gotip-openbsd-amd64 go@f22afc58 os.TestCopyFS (log) 
=== RUN   TestCopyFS
=== PAUSE TestCopyFS
=== CONT  TestCopyFS
    os_test.go:3321: comparing two directories: file "a" rw mode is -rw-------, want -rw-r--r--
--- FAIL: TestCopyFS (0.60s)
2024-10-04 19:47 gotip-linux-amd64-aliastypeparams go@d39bfafe os.TestCopyFS (log) 
=== RUN   TestCopyFS
=== PAUSE TestCopyFS
=== CONT  TestCopyFS
    os_test.go:3321: comparing two directories: file "a" rw mode is -rw-------, want -rw-r--r--
--- FAIL: TestCopyFS (0.02s)
2024-10-04 19:47 gotip-linux-amd64-staticlockranking go@d39bfafe os.TestCopyFS (log) 
=== RUN   TestCopyFS
=== PAUSE TestCopyFS
=== CONT  TestCopyFS
    os_test.go:3321: comparing two directories: file "a" rw mode is -rw-------, want -rw-r--r--
--- FAIL: TestCopyFS (0.00s)
2024-10-04 19:47 gotip-openbsd-amd64 go@d39bfafe os.TestCopyFS (log) 
=== RUN   TestCopyFS
=== PAUSE TestCopyFS
=== CONT  TestCopyFS
    os_test.go:3321: comparing two directories: file "a" rw mode is -rw-------, want -rw-r--r--
--- FAIL: TestCopyFS (0.35s)
2024-10-04 19:47 gotip-solaris-amd64 go@d39bfafe os.TestCopyFS (log) 
=== RUN   TestCopyFS
=== PAUSE TestCopyFS
=== CONT  TestCopyFS
    os_test.go:3350: comparing two directories: file "daVinci" rw mode is -rw-------, want -rw-r--r--
--- FAIL: TestCopyFS (0.42s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/618035 mentions this issue: Revert "os: check permissions of CopyFS copied files"

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/618055 mentions this issue: os: remove t.Parallel test in TestCopyFS

@FiloSottile
Copy link
Contributor

Happening all over the place, not just on OpenBSD.

https://build.golang.org/log/2dd58c271fde18950309e7abe0b54e7ef18b4fd5
https://build.golang.org/log/5abfe9fea3787707ef06b47600532aa2cf6c01ab

@dmitshur dmitshur moved this to Active in Test Flakes Oct 7, 2024
@dmitshur dmitshur added this to the Go1.24 milestone Oct 7, 2024
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. FixPending Issues that have a fix which has not yet been reviewed or submitted. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 7, 2024
@github-project-automation github-project-automation bot moved this from Active to Done in Test Flakes Oct 7, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "os" && test == "TestCopyFS"
2024-10-07 15:33 gotip-openbsd-amd64 go@a62566fb os.TestCopyFS (log) 
=== RUN   TestCopyFS
=== PAUSE TestCopyFS
=== CONT  TestCopyFS
    os_test.go:3321: comparing two directories: file "dir/x" rw mode is -rw-------, want -rw-r--r--
--- FAIL: TestCopyFS (0.24s)
2024-10-07 15:33 gotip-linux-amd64-aliastypeparams go@c050d42e os.TestCopyFS (log) 
=== RUN   TestCopyFS
=== PAUSE TestCopyFS
=== CONT  TestCopyFS
    os_test.go:3321: comparing two directories: file "dir/x" rw mode is -rw-------, want -rw-r--r--
--- FAIL: TestCopyFS (0.00s)
2024-10-07 15:33 gotip-linux-amd64-noopt go@c050d42e os.TestCopyFS (log) 
=== RUN   TestCopyFS
=== PAUSE TestCopyFS
=== CONT  TestCopyFS
    os_test.go:3321: comparing two directories: file "a" rw mode is -rw-------, want -rw-r--r--
--- FAIL: TestCopyFS (0.01s)
2024-10-07 15:33 gotip-linux-amd64-race go@c050d42e os.TestCopyFS (log) 
=== RUN   TestCopyFS
=== PAUSE TestCopyFS
=== CONT  TestCopyFS
    os_test.go:3350: comparing two directories: file "carl" rw mode is -rw-------, want -rw-r--r--
--- FAIL: TestCopyFS (0.05s)
2024-10-07 15:34 gotip-linux-386 go@63cd5a39 os.TestCopyFS (log) 
=== RUN   TestCopyFS
=== PAUSE TestCopyFS
=== CONT  TestCopyFS
    os_test.go:3350: comparing two directories: file "carl" rw mode is -rw-------, want -rw-r--r--
--- FAIL: TestCopyFS (0.04s)
2024-10-07 15:34 gotip-linux-amd64-boringcrypto go@311372c5 os.TestCopyFS (log) 
=== RUN   TestCopyFS
=== PAUSE TestCopyFS
=== CONT  TestCopyFS
    os_test.go:3321: comparing two directories: dir "dir" mode is drwxr-xr-x, want drwx------
--- FAIL: TestCopyFS (0.01s)
2024-10-07 15:34 gotip-linux-amd64-goamd64v3 go@311372c5 os.TestCopyFS (log) 
=== RUN   TestCopyFS
=== PAUSE TestCopyFS
=== CONT  TestCopyFS
    os_test.go:3321: comparing two directories: file "a" rw mode is -rw-------, want -rw-r--r--
--- FAIL: TestCopyFS (0.00s)
2024-10-07 15:35 gotip-linux-386-clang15 go@9a44b8e1 os.TestCopyFS (log) 
=== RUN   TestCopyFS
=== PAUSE TestCopyFS
=== CONT  TestCopyFS
    os_test.go:3321: comparing two directories: file "dir/x" rw mode is -rw-------, want -rw-r--r--
--- FAIL: TestCopyFS (0.00s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "os" && test == "TestCopyFS"
2024-10-07 15:33 gotip-openbsd-amd64 go@65679cfe os.TestCopyFS (log) 
=== RUN   TestCopyFS
=== PAUSE TestCopyFS
=== CONT  TestCopyFS
    os_test.go:3321: comparing two directories: file "b" rw mode is -rw-------, want -rw-r--r--
--- FAIL: TestCopyFS (0.39s)
2024-10-07 15:34 gotip-openbsd-amd64 go@ef14ba3e os.TestCopyFS (log) 
=== RUN   TestCopyFS
=== PAUSE TestCopyFS
=== CONT  TestCopyFS
    os_test.go:3321: comparing two directories: file "a" rw mode is -rw-------, want -rw-r--r--
--- FAIL: TestCopyFS (0.61s)
2024-10-07 15:34 gotip-openbsd-amd64 go@63cd5a39 os.TestCopyFS (log) 
=== RUN   TestCopyFS
=== PAUSE TestCopyFS
=== CONT  TestCopyFS
    os_test.go:3321: comparing two directories: file "b" rw mode is -rw-------, want -rw-r--r--
--- FAIL: TestCopyFS (0.42s)
2024-10-07 15:35 gotip-linux-amd64-race go@9a44b8e1 os.TestCopyFS (log) 
=== RUN   TestCopyFS
=== PAUSE TestCopyFS
=== CONT  TestCopyFS
    os_test.go:3321: comparing two directories: file "dir/x" rw mode is -rw-------, want -rw-r--r--
--- FAIL: TestCopyFS (0.01s)
2024-10-07 15:45 gotip-linux-amd64-race go@092d18b3 os.TestCopyFS (log) 
=== RUN   TestCopyFS
=== PAUSE TestCopyFS
=== CONT  TestCopyFS
    os_test.go:3350: comparing two directories: file "carl" rw mode is -rw-------, want -rw-r--r--
--- FAIL: TestCopyFS (0.05s)

— watchflakes

@xieyuschen
Copy link
Contributor

Happening all over the place, not just on OpenBSD.

https://build.golang.org/log/2dd58c271fde18950309e7abe0b54e7ef18b4fd5 https://build.golang.org/log/5abfe9fea3787707ef06b47600532aa2cf6c01ab

Hi @FiloSottile , sorry for introducing the fragile test before. It's caused by another parallel test modifies the system umask but the TestCopyFS relies on it. The commit 4b4b2fc has fixed it and I don't see any failure after my fix. Thanks:)

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "os" && test == "TestCopyFS"
2024-10-07 15:33 gotip-solaris-amd64 go@534d6a1a os.TestCopyFS (log) 
=== RUN   TestCopyFS
=== PAUSE TestCopyFS
=== CONT  TestCopyFS
    os_test.go:3350: comparing two directories: file "daVinci" rw mode is -rw-------, want -rw-r--r--
--- FAIL: TestCopyFS (0.23s)

— watchflakes

@xieyuschen
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "os" && test == "TestCopyFS"

2024-10-07 15:33 gotip-solaris-amd64 go@534d6a1a os.TestCopyFS (log)
— watchflakes

ditto, could rebase commit 4b4b2fc and it will be fixed.

@prattmic
Copy link
Member

prattmic commented Oct 9, 2024

On my personal machine, I am still seeing failures at 93166e2 (after 4b4b2fc):

$ go test os
--- FAIL: TestCopyFS (0.00s)
    os_test.go:3321: comparing two directories: file "dir/x" execute mode is ---x--x---, want ---x--x--x
FAIL
FAIL    os      19.020s
FAIL

go version: go version devel go1.24-93166e29d3 Wed Oct 9 20:12:00 2024 +0000 linux/amd64

go env:

GO111MODULE=''
GOARCH='amd64'
GOAUTH='netrc'
GOBIN=''
GOCACHE='/usr/local/google/home/mpratt/.cache/go-build'
GOENV='/usr/local/google/home/mpratt/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/usr/local/google/home/mpratt/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/usr/local/google/home/mpratt/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/google/home/mpratt/src/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/google/home/mpratt/src/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='devel go1.24-93166e29d3 Wed Oct 9 20:12:00 2024 +0000'
GODEBUG=''
GOTELEMETRY='on'
GOTELEMETRYDIR='/usr/local/google/home/mpratt/.config/go/telemetry'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/usr/local/google/home/mpratt/src/go/src/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build3793695447=/tmp/go-build -gno-record-gcc-switches'

@prattmic prattmic reopened this Oct 9, 2024
@github-project-automation github-project-automation bot moved this from Done to Active in Test Flakes Oct 9, 2024
@ianlancetaylor
Copy link
Member

@prattmic Does it fail consistently? What is your umask value?

@prattmic
Copy link
Member

prattmic commented Oct 9, 2024

It does. My shell reports my umask is 027, which sounds relevant given the test is missing x.

@ianlancetaylor
Copy link
Member

ianlancetaylor commented Oct 9, 2024 •
edited by gabyhelp
Loading

Sent you CL 619176.

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/619176 mentions this issue: os: handle umask comparing execute mode in verifyCopyFS

@github-project-automation github-project-automation bot moved this from Active to Done in Test Flakes Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done.
Projects
Test Flakes
Archived in project
Milestone
Go1.24
Development

No branches or pull requests
6 participants
@FiloSottile @prattmic @dmitshur @ianlancetaylor @gopherbot @xieyuschen