Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: x/image/webp: errInvalidFormat should be exported #69908

Open
nemith opened this issue Oct 16, 2024 · 1 comment
Open

proposal: x/image/webp: errInvalidFormat should be exported #69908

nemith opened this issue Oct 16, 2024 · 1 comment
Labels
Milestone

Comments

@nemith
Copy link
Contributor

nemith commented Oct 16, 2024

Proposal Details

When an unknown image type gets decoded in the x/image/webp a unexported error is returned . This should probably be exported.

This would allow us to catch it better than doing string parsing to catch the error type.

https://cs.opensource.google/go/x/image/+/refs/tags/v0.21.0:webp/decode.go;l=19

A separate error with the same message is used here as well and should be updated to use the same type.
https://cs.opensource.google/go/x/image/+/refs/tags/v0.21.0:webp/decode.go;l=176

@gopherbot gopherbot added this to the Proposal milestone Oct 16, 2024
@ianlancetaylor ianlancetaylor moved this to Incoming in Proposals Oct 17, 2024
@ianlancetaylor
Copy link
Member

CC @nigeltao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Incoming
Development

No branches or pull requests

3 participants