Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: gotip-linux-amd64-race slowdown from 12m to 50m #70008

Closed
mknyszek opened this issue Oct 23, 2024 · 2 comments
Closed

runtime: gotip-linux-amd64-race slowdown from 12m to 50m #70008

mknyszek opened this issue Oct 23, 2024 · 2 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.24

Comments

@mknyszek
Copy link
Contributor

I noticed that the -race trybot was taking a long time, and I think I narrowed it down to this commit as the culprit:

image

Implicated commit is 488e2d1, which tracks with test timing numbers. Running the benchmarks in the runtime once took ~2500s or ~40 minutes.

CC @prattmic
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Oct 23, 2024
@gabyhelp
Copy link

Related Issues and Documentation

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@mknyszek mknyszek changed the title runtime: gotip-linux-amd64-race slows down from 12m -> 50m as of 488e2d18d9d8ac8f51a5e1ea297adaa50c9f4870 runtime: gotip-linux-amd64-race slowdown from 12m to 50m Oct 23, 2024
@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 28, 2024
@cagedmantis cagedmantis added this to the Go1.24 milestone Oct 28, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/623335 mentions this issue: runtime: skip most map benchmark combinations by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.24
Development

No branches or pull requests
4 participants
@cagedmantis @mknyszek @gopherbot @gabyhelp