Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google.golang.org/protobuf: TestIntegration/Go1.23.0/ProtoLegacy failures #70096

Open
gopherbot opened this issue Oct 29, 2024 · 1 comment
Open
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "google.golang.org/protobuf" && test == "TestIntegration/Go1.23.0/ProtoLegacy"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestIntegration/Go1.23.0/ProtoLegacy
    integration_test.go:137: executing (go1.23.0 test -tags protolegacy ./...): exit status 1
        ?   	google.golang.org/protobuf/cmd/protoc-gen-go/internal_gengo	[no test files]
        ok  	google.golang.org/protobuf	0.097s
        ok  	google.golang.org/protobuf/cmd/protoc-gen-go	0.109s
        ok  	google.golang.org/protobuf/compiler/protogen	0.096s
        ok  	google.golang.org/protobuf/encoding	0.117s [no tests to run]
        ok  	google.golang.org/protobuf/encoding/protodelim	0.116s
        ok  	google.golang.org/protobuf/encoding/protojson	0.186s
        ok  	google.golang.org/protobuf/encoding/prototext	0.194s
...
        --- FAIL: TestHasExtensionNoAlloc (0.02s)
            --- FAIL: TestHasExtensionNoAlloc/Eager (0.00s)
                extension_test.go:156: proto.HasExtension should not allocate, but allocated 1.00x per run
        FAIL
        FAIL	google.golang.org/protobuf/proto	0.353s
        ok  	google.golang.org/protobuf/reflect/protodesc	0.141s
        ok  	google.golang.org/protobuf/reflect/protorange	0.226s
        ok  	google.golang.org/protobuf/reflect/protoreflect	0.071s
        ok  	google.golang.org/protobuf/reflect/protoregistry	0.122s
        ok  	google.golang.org/protobuf/testing/protocmp	0.185s
        ok  	google.golang.org/protobuf/testing/protopack	0.049s
        ok  	google.golang.org/protobuf/testing/prototest	1.064s
        ok  	google.golang.org/protobuf/types/dynamicpb	0.121s
        ok  	google.golang.org/protobuf/types/known/anypb	0.057s
        ok  	google.golang.org/protobuf/types/known/durationpb	0.011s
        ok  	google.golang.org/protobuf/types/known/fieldmaskpb	0.024s
        ok  	google.golang.org/protobuf/types/known/structpb	0.021s
        ok  	google.golang.org/protobuf/types/known/timestamppb	0.029s
        FAIL
--- FAIL: TestIntegration/Go1.23.0/ProtoLegacy (66.75s)

watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "google.golang.org/protobuf" && test == "TestIntegration/Go1.23.0/ProtoLegacy"
2024-10-28 09:07 z_protobuf-go1.23-linux-amd64-longtest protobuf@0517e5af release-branch.go1.23@58babf6e google.golang.org/protobuf.TestIntegration/Go1.23.0/ProtoLegacy (log)
=== RUN   TestIntegration/Go1.23.0/ProtoLegacy
    integration_test.go:137: executing (go1.23.0 test -tags protolegacy ./...): exit status 1
        ?   	google.golang.org/protobuf/cmd/protoc-gen-go/internal_gengo	[no test files]
        ok  	google.golang.org/protobuf	0.097s
        ok  	google.golang.org/protobuf/cmd/protoc-gen-go	0.109s
        ok  	google.golang.org/protobuf/compiler/protogen	0.096s
        ok  	google.golang.org/protobuf/encoding	0.117s [no tests to run]
        ok  	google.golang.org/protobuf/encoding/protodelim	0.116s
        ok  	google.golang.org/protobuf/encoding/protojson	0.186s
        ok  	google.golang.org/protobuf/encoding/prototext	0.194s
...
        --- FAIL: TestHasExtensionNoAlloc (0.02s)
            --- FAIL: TestHasExtensionNoAlloc/Eager (0.00s)
                extension_test.go:156: proto.HasExtension should not allocate, but allocated 1.00x per run
        FAIL
        FAIL	google.golang.org/protobuf/proto	0.353s
        ok  	google.golang.org/protobuf/reflect/protodesc	0.141s
        ok  	google.golang.org/protobuf/reflect/protorange	0.226s
        ok  	google.golang.org/protobuf/reflect/protoreflect	0.071s
        ok  	google.golang.org/protobuf/reflect/protoregistry	0.122s
        ok  	google.golang.org/protobuf/testing/protocmp	0.185s
        ok  	google.golang.org/protobuf/testing/protopack	0.049s
        ok  	google.golang.org/protobuf/testing/prototest	1.064s
        ok  	google.golang.org/protobuf/types/dynamicpb	0.121s
        ok  	google.golang.org/protobuf/types/known/anypb	0.057s
        ok  	google.golang.org/protobuf/types/known/durationpb	0.011s
        ok  	google.golang.org/protobuf/types/known/fieldmaskpb	0.024s
        ok  	google.golang.org/protobuf/types/known/structpb	0.021s
        ok  	google.golang.org/protobuf/types/known/timestamppb	0.029s
        FAIL
--- FAIL: TestIntegration/Go1.23.0/ProtoLegacy (66.75s)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: No status
Development

No branches or pull requests

1 participant