Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: -covermode atomic should be used when -race is requested #7013

Closed
mikioh opened this issue Dec 26, 2013 · 5 comments
Closed

testing: -covermode atomic should be used when -race is requested #7013

mikioh opened this issue Dec 26, 2013 · 5 comments
Assignees
@robpike
Labels
FrozenDueToAge RaceDetector
Milestone
Go1.3

Comments

@mikioh
Copy link
Contributor

@mikioh mikioh commented Dec 26, 2013 

See attached.

Attachments:

  1. output.txt (6268 bytes)
@mikioh
Copy link
Contributor Author

@mikioh mikioh commented Dec 26, 2013

Comment 1:

It shows the output of "go test -race -cover" at pkg/bytes.

Loading

@remyoudompheng
Copy link
Contributor

@remyoudompheng remyoudompheng commented Dec 26, 2013

Comment 3:

Maybe -covermode atomic should be the default for race-detection builds ?

Loading

@davecheney
Copy link
Contributor

@davecheney davecheney commented Feb 3, 2014

Comment 4:

@remy this sounds like a good solution.

Labels changed: added release-go1.3.

Status changed to Accepted.

Loading

@rsc
Copy link
Contributor

@rsc rsc commented Mar 11, 2014

Comment 5:

Owner changed to @robpike.

Loading

@robpike
Copy link
Contributor

@robpike robpike commented Mar 18, 2014

Comment 6:

This issue was closed by revision 108a4dc.

Status changed to Fixed.

Loading

@rsc rsc added this to the Go1.3 milestone Apr 14, 2015
@rsc rsc removed the release-go1.3 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@robpike robpike

Labels
FrozenDueToAge RaceDetector
Projects
None yet
Milestone
Go1.3
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
@davecheney @mikioh @rsc @remyoudompheng @robpike @gopherbot