Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: pull diagnostic support, continued #70199

Open
findleyr opened this issue Nov 5, 2024 · 0 comments
Open

x/tools/gopls: pull diagnostic support, continued #70199

findleyr opened this issue Nov 5, 2024 · 0 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Member

findleyr commented Nov 5, 2024

Following up on #53275, there are a few more improvements I'd like to make to pull diagnostics so that they are comparable in performance to push diagnostics, at which point we can enable them by default:

  • Rewrite the bottom-up graph traversal of analysis nodes: in the common case, all dependency information will be a cache hit (including memoized keys and encoded summaries in the file cache). Therefore, the bottom-up traversal of the full graph is a significant overhead when repeatedly querying diagnostics.
  • Rewrite the bottom-up graph traversal to build package handles, for similar reasons.
  • Refactor the fact decoder to operate on shallow fact encoding, so that facts in transitive dependencies can be retrieved (and decoded) on demand. (This could have a huge impact on performance).
  • Add support for go.mod and go.work diagnostics (requires refactoring the way we diagnose the workspace).

CC @adonovan

@findleyr findleyr added this to the gopls/v0.18.0 milestone Nov 5, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants