Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: don't link command-line-arguments packages in hover #70226

Open
findleyr opened this issue Nov 6, 2024 · 0 comments
Open

x/tools/gopls: don't link command-line-arguments packages in hover #70226

findleyr opened this issue Nov 6, 2024 · 0 comments
Assignees
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Member

findleyr commented Nov 6, 2024

This is a follow-up issue to fix some remaining bugs in hovering over command-line-arguments packages.

  1. We should url-escape package paths.

  2. We should not offer links to command-line-arguments packages, as they are not real.

           So, to summarize, there are two bugs here:
    
           1. gopls is not properly url-escaping package paths.
           3. ~gopls is not providing accurate hover information for builtins, when viewing the builtin file.~
    
           (1) should be fixed by a relatively straighforward application of url escaping. Assigning to our new team member @h9jiang as this is a good starter exercise for bug fixing and writing a test.
    
           On the other hand, (2) might require a more sweeping refactoring of how we handle the builtin file and unsafe packages, and is just about the polar opposite of a good starter bug: requires familiarity with nitty-gritty details of the codebase. I will do this part.
    

Originally posted by @findleyr in #68026 (comment)

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 6, 2024
@gopherbot gopherbot added this to the Unreleased milestone Nov 6, 2024
@h9jiang h9jiang self-assigned this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants