Skip to content

x/tools/cmd/goimports: confusing error message when file contains CRLF #70297

@abitrolly

Description

@abitrolly

Go version

go version go1.23.3 windows/amd64

Output of go env in your module/workspace:

set GO111MODULE=
  set GOARCH=amd64
  set GOBIN=
  set GOCACHE=C:\Users\runneradmin\AppData\Local\go-build
  set GOENV=C:\Users\runneradmin\AppData\Roaming\go\env
  set GOEXE=.exe
  set GOEXPERIMENT=
  set GOFLAGS=
  set GOHOSTARCH=amd64
  set GOHOSTOS=windows
  set GOINSECURE=
  set GOMODCACHE=C:\Users\runneradmin\go\pkg\mod
  set GONOPROXY=
  set GONOSUMDB=
  set GOOS=windows
  set GOPATH=C:\Users\runneradmin\go
  set GOPRIVATE=
  set GOPROXY=https://proxy.golang.org,direct
  set GOROOT=C:\hostedtoolcache\windows\go\1.23.3\x64
  set GOSUMDB=sum.golang.org
  set GOTMPDIR=
  set GOTOOLCHAIN=auto
  set GOTOOLDIR=C:\hostedtoolcache\windows\go\1.23.3\x64\pkg\tool\windows_amd64
  set GOVCS=
  set GOVERSION=go1.23.3
  set GODEBUG=
  set GOTELEMETRY=local
  set GOTELEMETRYDIR=C:\Users\runneradmin\AppData\Roaming\go\telemetry
  set GCCGO=gccgo
  set GOAMD64=v1
  set AR=ar
  set CC=gcc
  set CXX=g++
  set CGO_ENABLED=1
  set GOMOD=D:\a\sflags\sflags\go.mod
  set GOWORK=
  set CGO_CFLAGS=-O2 -g
  set CGO_CPPFLAGS=
  set CGO_CXXFLAGS=-O2 -g
  set CGO_FFLAGS=-O2 -g
  set CGO_LDFLAGS=-O2 -g
  set PKG_CONFIG=pkg-config
  set GOGCCFLAGS=-m64 -mthreads -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=C:\Users\RUNNER~1\AppData\Local\Temp\go-build1760277560=/tmp/go-build -gno-record-gcc-switches

What did you do?

Run golangci-lint which invokes goimports on Windows machine.

https://github.com/urfave/sflags/actions/runs/11786526137/job/32829983012

Other reports are visible from golangci/golangci-lint#580

What did you see happen?

cmd\genvalues\main.go:1: File is not `goimports`-ed (goimports)

What did you expect to see?

cmd\genvalues\main.go:1: File contains CRLF linefeeds (goimports)

Metadata

Metadata

Assignees

No one assigned

    Labels

    NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.ToolsThis label describes issues relating to any tools in the x/tools repository.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions