Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: std's reflect expands with zero subpackages in the directory view #70313

Open
mvdan opened this issue Nov 13, 2024 · 2 comments
Open

Comments

@mvdan
Copy link
Member

mvdan commented Nov 13, 2024

What is the URL of the page with the issue?

https://pkg.go.dev/std

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64; rv:132.0) Gecko/20100101 Firefox/132.0

Screenshot

img-2024-11-13-10-29-54

What did you do?

Tried expanding a number of std packages in the directory view to see subpackages.

What did you see happen?

Any package with the arrow pointing right should expand with subpackages when clicking on the arrow.

What did you expect to see?

Most packages do that, except reflect, which expands into nothing.

This might be because reflect only has internal sub-packages:

$ go list reflect/...
reflect
reflect/internal/example1
reflect/internal/example2
@mvdan mvdan added the pkgsite label Nov 13, 2024
@gopherbot gopherbot added this to the Unreleased milestone Nov 13, 2024
@hyangah
Copy link
Contributor

hyangah commented Nov 13, 2024

There are internal/example1 and internal/exmple2 packages underneath in the html table which become visible when click on "Show Internal".

Screenshot 2024-11-13 at 1 11 15 PM

@mvdan
Copy link
Member Author

mvdan commented Nov 14, 2024

I see. My intuition is that the dropdown UI should not appear unless it actually expands into something. So perhaps the dropdown should appear only when enabling "show internal".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants