Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: (nil)*File.Sync() returns syscall.EINVAL on posix platforms #7043

Closed
davecheney opened this issue Jan 1, 2014 · 2 comments
Closed

os: (nil)*File.Sync() returns syscall.EINVAL on posix platforms #7043

davecheney opened this issue Jan 1, 2014 · 2 comments
Milestone

Comments

@davecheney
Copy link
Contributor

@davecheney davecheney commented Jan 1, 2014

What steps will reproduce the problem?

*File.Sync() returns syscall.EINVAL on posix platforms when *File is nil, this is
different to all the other *File methods which return ErrInvalid.

What is the expected output? What do you see instead?

Although not documented, the other methods on this type lead me to believe that
*File.Sync() should return ErrInvalid on all platforms when the receiver is nil.

Please use labels and text to provide additional information.
@robpike

This comment has been minimized.

Copy link
Contributor

@robpike robpike commented Jan 3, 2014

Comment 1:

SGTM
@davecheney

This comment has been minimized.

Copy link
Contributor Author

@davecheney davecheney commented Jan 3, 2014

Comment 2:

This issue was closed by revision f2e946f.

Status changed to Fixed.

@rsc rsc added this to the Go1.3 milestone Apr 14, 2015
@rsc rsc removed the release-go1.3 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.