Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/golangbuild: update result_adapter to handle Go 1.24's go test -json output #70435

Open
dmitshur opened this issue Nov 19, 2024 · 2 comments
Open

x/build/cmd/golangbuild: update result_adapter to handle Go 1.24's go test -json output #70435

dmitshur opened this issue Nov 19, 2024 · 2 comments
Assignees
@dmitshur
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.24

Comments

@dmitshur
Copy link
Contributor

This is a continunuation of #70402 (comment), tracking the change on the LUCI side.

CC @golang/release, @mknyszek.
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Nov 19, 2024
@dmitshur dmitshur added this to the Go1.24 milestone Nov 19, 2024
@dmitshur dmitshur self-assigned this Nov 19, 2024
@dmitshur dmitshur moved this to In Progress in Go Release Nov 19, 2024
@gabyhelp
Copy link

Related Code Changes

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@dmitshur dmitshur mentioned this issue Nov 19, 2024
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/634237 mentions this issue: main.star: extend gotestjsonbuildtext=1 to NEXT_GO

gopherbot pushed a commit to golang/build that referenced this issue Dec 7, 2024
@dmitshur @mknyszek
main.star: extend gotestjsonbuildtext=1 to NEXT_GO
0c6614a 
We'll drop it from tip and the new release-branch.go1.24 branch as soon
as result_adapter is ready to handle events that contain ImportPath but
not Package fields, but that's not the case this week.

For golang/go#70402.
For golang/go#70435.

Change-Id: Ibd5ce399e2b8e072eb9066a1d304964b41f6cc1b
Reviewed-on: https://go-review.googlesource.com/c/build/+/634237
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitshur dmitshur

Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Status: In Progress
Milestone
Go1.24
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @gabyhelp