New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: fmt: State Flag(int) should be Flag(rune) #7047

Open
kortschak opened this Issue Jan 1, 2014 · 3 comments

Comments

Projects
None yet
5 participants
@kortschak
Copy link
Contributor

kortschak commented Jan 1, 2014

This issue is really just a note.

The Flag method of fmt.State takes an int argument but represents a 'character'.
Probably it should have been changed from int to rune when the rune alias was introduced
(or byte - given all flags are ASCII).

Which version are you using?  (run 'go version')

go1.2
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

ianlancetaylor commented Jan 2, 2014

Comment 1:

Labels changed: added go2.

@minux

This comment has been minimized.

Copy link
Member

minux commented Jan 27, 2014

Comment 2:

Labels changed: added repo-main.

@davecheney

This comment has been minimized.

Copy link
Contributor

davecheney commented Jan 31, 2014

Comment 3:

Labels changed: added release-none.

Status changed to Accepted.

@rsc rsc added this to the Unplanned milestone Apr 10, 2015

@rsc rsc removed release-none labels Apr 10, 2015

@rsc rsc changed the title fmt: fmt.(State).Flag() takes an int argument fmt: State Flag(int) should be Flag(rune) Jun 17, 2017

@rsc rsc changed the title fmt: State Flag(int) should be Flag(rune) proposal: fmt: State Flag(int) should be Flag(rune) Jun 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment