-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile/internal/importer: flip enable alias to true [1.23 backport] #70517
Comments
Change https://go.dev/cl/629997 mentions this issue: |
Thoughts for cherrypicking: Setting |
Change https://go.dev/cl/631855 mentions this issue: |
My investigation makes me believe that this should be safe enough for 1.23. The CL to cherry pick would be https://go.dev/cl/631855. |
When could I expect a 1.23.x release with this fix? I was hoping that would be the case with 1.23.4, given that the patch was approved last week, but unfortunately I see it's not the case. |
@mvdan The patch has been approved on gerrit, but the status on the issue is CherryPickCandidate. For it to go forward, its must be CherryPickApproved. See https://go.dev/wiki/MinorReleases. (Yes this can be confusing.) |
I see. Hopefully this can move along relatively quickly at this point, as I am unable to use alias tracking still. |
This issue is created to request a backport at go1.23 to fix #70394. The issue doesn't exist in go1.24(master) as the code has refactored a bit before and fixed this issue.
go/src/cmd/compile/internal/importer/ureader.go
Line 34 in b0bbfb1
The backport fix allows ureader to read exportdata with alias correctly and it doesn't affect the correctness of
compile
to construct exportdata for the following packages.@timothy-king
The text was updated successfully, but these errors were encountered: