Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: stuck extended CONNECT requests #70658

Open
neild opened this issue Dec 3, 2024 · 1 comment
Open

x/net/http2: stuck extended CONNECT requests #70658

neild opened this issue Dec 3, 2024 · 1 comment
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@neild
Copy link
Contributor

neild commented Dec 3, 2024 •
edited by gabyhelp
Loading

@aojea points out in https://go-review.googlesource.com/c/net/+/610977/comment/2f78d788_69fe1833/ that HTTP/2 extended CONNECT requests can get stuck waiting for a SETTINGS frame, due to a failure to close ClientConn.seenSettingsChan on some error paths.
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/633277 mentions this issue: http2: avoid extended CONNECT hang when connection breaks during startup

@mknyszek mknyszek added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 3, 2024
@mknyszek mknyszek added this to the Unreleased milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@neild @mknyszek @gopherbot