Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: TestRootDirFS failures on linux-mips64 and linux-mips64le #70659

Closed
mknyszek opened this issue Dec 3, 2024 · 4 comments
Closed

os: TestRootDirFS failures on linux-mips64 and linux-mips64le #70659

mknyszek opened this issue Dec 3, 2024 · 4 comments
Assignees
@neild
Labels
arch-mips NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.24

Comments

@mknyszek
Copy link
Contributor

mknyszek commented Dec 3, 2024

For example: https://build.golang.org/log/5d553b659dedaa835802a79cf1866ed511913cbf

CC @neild maybe?
@mknyszek mknyszek added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-mips labels Dec 3, 2024
@mknyszek mknyszek added this to the Backlog milestone Dec 3, 2024
@neild neild self-assigned this Dec 3, 2024
@griesemer griesemer modified the milestones: Backlog, Go1.24 Dec 3, 2024
@neild
Copy link
Contributor

neild commented Dec 3, 2024

syscall.fstatat is busted on linux/mips64, since it passes a *Stat_t to a syscall that expects a *stat_t.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/633280 mentions this issue: syscall, internal/syscall/unix: fix fstatat on linux/mips64

@cherrymui cherrymui mentioned this issue Dec 3, 2024
Open
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/636836 mentions this issue: [release-branch.go1.24] syscall, internal/syscall/unix: fix fstatat on linux/mips64

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/637739 mentions this issue: internal/syscall/unix: apply fstatat fix to linux/mips64le

gopherbot pushed a commit that referenced this issue Dec 21, 2024
@cherrymui
internal/syscall/unix: apply fstatat fix to linux/mips64le
06b191e 
Apply CL 633280 to linux/mips64le, as it has the same struct as
mips64.

Updates #70659.

Change-Id: Ibab635e69e44682eb214bf6a00f4cd75816b2d34
Reviewed-on: https://go-review.googlesource.com/c/go/+/637739
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 8, 2025
wyf9661 pushed a commit to wyf9661/go that referenced this issue Jan 21, 2025
@neild @wyf9661
syscall, internal/syscall/unix: fix fstatat on linux/mips64
e226624 
On linux/mips64, the syscall.Stat_t struct does not match the
kernel version of the struct. Functions that operate on a Stat_t
translate between it and the kernel struct.

The fstatat function was not doing this translation.
Make it do so.

Export a syscall.Fstatat on mips64 for usage by
internal/syscall/unix. Perhaps we should just do this on all
architectures, but this is the smaller change for now.

Fixes golang#70659

Change-Id: I38e36473689be25861953b418c9abc5b270a7bcf
Reviewed-on: https://go-review.googlesource.com/c/go/+/633280
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
wyf9661 pushed a commit to wyf9661/go that referenced this issue Jan 21, 2025
@cherrymui @wyf9661
internal/syscall/unix: apply fstatat fix to linux/mips64le
9823c75 
Apply CL 633280 to linux/mips64le, as it has the same struct as
mips64.

Updates golang#70659.

Change-Id: Ibab635e69e44682eb214bf6a00f4cd75816b2d34
Reviewed-on: https://go-review.googlesource.com/c/go/+/637739
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neild neild

Labels
arch-mips NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.24
Development

No branches or pull requests
5 participants
@neild @mknyszek @dmitshur @griesemer @gopherbot