Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website/internal/gitfs: unreachable code in Repo.fetch #70688

Closed
seankhliao opened this issue Dec 5, 2024 · 2 comments
Closed

x/website/internal/gitfs: unreachable code in Repo.fetch #70688

seankhliao opened this issue Dec 5, 2024 · 2 comments
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. website
Milestone
Unreleased

Comments

@seankhliao
Copy link
Member

go test -vet=all on x/website fails because there's a continue that makes the error return unreachable.
Without seeing if it actually printed anything, I'm not sure if it's safe to remove?

https://go.googlesource.com/website/+/7557e6c9b0584c38038af194da116695e92b9db5/internal/gitfs/git.go#260

cc @rsc @dmitshur
@seankhliao seankhliao added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. website labels Dec 5, 2024
@gopherbot gopherbot added this to the Unreleased milestone Dec 5, 2024
@ansaba
Copy link

ansaba commented Dec 5, 2024 •
edited by gabyhelp
Loading

The code was added in https://go-review.googlesource.com/c/website/+/328213 for tip.golang.org
cc: @rsc

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/634456 mentions this issue: internal/gitfs: remove apparent debugging dreg

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. FixPending Issues that have a fix which has not yet been reviewed or submitted. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Dec 8, 2024
@dmitshur dmitshur mentioned this issue Dec 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. website
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@ansaba @dmitshur @gopherbot @seankhliao