x/tools/gopls: fillStruct mess-up code format

[echoface]

gopls version

v0.16.2

go env

GO111MODULE=''
GOARCH='arm64'
GOBIN=''
GOCACHE='/Users/xxx/Library/Caches/go-build'
GOENV='/Users/xxx/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/xxxx/go/pkg/mod'
GOOS='darwin'
GOPATH='/Users/xxx/go'
GOROOT='/opt/homebrew/Cellar/go/1.23.2/libexec'
GOSUMDB='sum.golang.google.cn'
GOTMPDIR=''
GOTOOLCHAIN='local'
GOTOOLDIR='/opt/homebrew/Cellar/go/1.23.2/libexec/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.23.2'
GODEBUG=''
GOTELEMETRY='local'
GCCGO='gccgo'
GOARM64='v8.0'
AR='ar'
CC='cc'
CXX='c++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/z0/svszlpj10dj930l0y9yn9k3h0000gn/T/go-build1883146030=/tmp/go-build -gno-record-gcc-switches -fno-common'

What did you do?

run code action:
refactor.rewrite

What did you see happen?

What did you expect to see?

Editor and settings

nvim builtin lsp

Logs

No response

[gabyhelp]

Related Issues

• x/tools/gopls: improve error message when using wrong go command with Go source distribution #35520
• x/tools/gopls: Implement action should ignore importing the current package #61830 (closed)
• x/tools/gopls: package (still) not found when "linksInHover": "gopls" #68223
• x/tools/gopls: #52425 (closed)
• x/tools/gopls: negated build flag causes error #59346
• x/tools/gopls: does not properly support go module on spacemac #33612 (closed)
• x/tools/gopls: panic and crash in golang.org/x/telemetry/internal/counter #64577 (closed)
• go build #52634 (closed)
• x/tools/gopls: gopls stopped responding when gomod failed. #38818 (closed)
• x/tools/gopls: undeclared name when accessing symbols from other files #35337 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[echoface]

[DEBUG][2024-12-05 14:16:08] .../vim/lsp/rpc.lua:408	"rpc.receive"	{  id = 16,  jsonrpc = "2.0",  result = {    data = {      arguments = { {          Fix = "fillstruct",          Range = {            ["end"] = {              character = 2,              line = 22            },            start = {              character = 9,              line = 16            }          },          ResolveEdits = true,          URI = "file:///Users/bytedance/echoface/playground/go/main.go"        } },      command = "gopls.apply_fix",      title = "Fill AAA"    },    edit = {      documentChanges = { {          edits = { {              newText = "AAA{\n\t\tNodes: []*Node{{Value: 0}, {Value: 0}},\n\t\tEdges: map[*Node]*Node{},\n\t}",              range = {                ["end"] = {                  character = 2,                  line = 22                },                start = {                  character = 9,                  line = 16                }              }            } },          textDocument = {            uri = "file:///Users/bytedance/echoface/playground/go/main.go",            version = 7          }        } }    },    kind = "refactor.rewrite",    title = "Fill AAA"  }}

pretty response

local x = {
    id = 16,
    jsonrpc = "2.0",
    result = {
        data = {
            arguments = {
                {
                    Fix = "fillstruct",
                    Range = { ["end"] = {
                            character = 2,
                            line = 22
                        },
                        start = {
                            character = 9,
                            line = 16
                        }
                    },
                    ResolveEdits = true,
                    URI = "file:///Users/xxx/echoface/playground/go/main.go"
                }
            },
            command = "gopls.apply_fix",
            title = "Fill AAA"
        },
        edit = {
            documentChanges = {
                {
                    edits = {
                        {
                            newText = "AAA{\n\t\tNodes: []*Node{{Value: 0}, {Value: 0}},\n\t\tEdges: map[*Node]*Node{},\n\t}",
                            range = { ["end"] = {
                                    character = 2,
                                    line = 22
                                },
                                start = {
                                    character = 9,
                                    line = 16
                                }
                            }
                        }
                    },
                    textDocument = {
                        uri = "file:///Users/xxx/echoface/playground/go/main.go",
                        version = 7
                    }
                }
            }
        },
        kind = "refactor.rewrite",
        title = "Fill AAA"
    }
}

[findleyr]

To be clear: the ask here is to preserve the existing formatting of node fields, right?

My guess is that we reformat the entire node with no position information. In that case, I think this should be straightforward to fix.

[echoface]

To be clear: the ask here is to preserve the existing formatting of node fields, right?

My guess is that we reformat the entire node with no position information. In that case, I think this should be straightforward to fix.

"To be clear: the ask here is to preserve the existing formatting of node fields, right?"

• yes, gopls join element Nodes into oneline now