Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: cmd/go: go test flag -skip should be cacheable #70692

Open
zgzhong opened this issue Dec 5, 2024 · 1 comment
Open

proposal: cmd/go: go test flag -skip should be cacheable #70692

zgzhong opened this issue Dec 5, 2024 · 1 comment
Labels
Milestone

Comments

@zgzhong
Copy link

zgzhong commented Dec 5, 2024

Proposal Details

Running tests with the -skip flag should be able to use the test result cache.

In the original design of the test result cache (#11193), the test flag -run is a cacheable flag. However, the subsequent proposal (#41583) that added the -skip flag to go test but did not make it cacheable.

Both -skip and -run are flags used to match or filter the test cases. Since the -run parameter is cacheable, the -skip parameter should also be cacheable, too.

@gopherbot gopherbot added this to the Proposal milestone Dec 5, 2024
@ianlancetaylor ianlancetaylor moved this to Incoming in Proposals Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Incoming
Development

No branches or pull requests

3 participants