Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/internal/relui: TestSecurity/success failures #70694

Closed
gopherbot opened this issue Dec 5, 2024 · 2 comments
Closed

x/build/internal/relui: TestSecurity/success failures #70694

gopherbot opened this issue Dec 5, 2024 · 2 comments
Assignees
@dmitshur
Labels
Builders x/build issues (builders, bots, dashboards) FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Dec 5, 2024 •
edited by dmitshur
Loading 

#!watchflakes
default <- pkg == "golang.org/x/build/internal/relui" && `race detected during execution of test`

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestSecurity/success
    buildrelease_test.go:705: task Select source spec: started
    buildrelease_test.go:705: task Read security ref: started
    buildrelease_test.go:705: task Timestamp release: started
    buildrelease_test.go:705: task Check branch state matches source archive: started
    buildrelease_test.go:705: task Wait for version CL submission: started
    buildrelease_test.go:705: task Wait for advisory builders: started
    buildrelease_test.go:705: task Tag version: started
    buildrelease_test.go:705: task Generate VERSION file: started
    buildrelease_test.go:705: task Push issues: started
...
    buildrelease_test.go:705: task Publish to website: started
    buildrelease_test.go:705: task Start Google Docker build: started
    buildrelease_test.go:724: task Publish to website: LOG: Published "go1.18rc1.src.tar.gz".
    buildrelease_test.go:724: task Publish to website: LOG: Published all 1 files for go1.18rc1.
    buildrelease_test.go:709: task Start Google Docker build: done: {docker-build-project build-1976034929531293877 }
    buildrelease_test.go:705: task Await Google Docker build: started
    buildrelease_test.go:709: task Publish to website: done: {go1.18rc1 [{go1.18rc1.src.tar.gz   go1.18rc1 866cd3a4fe047a829796d9afad6e9349244936ac1ecb424089d805775956e84a 1398 source}]}
    buildrelease_test.go:709: task Await Google Docker build: done: here's some build detail
    testing.go:1398: race detected during execution of test
--- FAIL: TestSecurity/success (1.11s)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 5, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/build/internal/relui" && test == "TestSecurity/success"
2024-12-05 17:14 x_build-go1.22-linux-amd64-longtest-race build@bbd61d3e release-branch.go1.22@8f3f22ee x/build/internal/relui.TestSecurity/success (log) 
=== RUN   TestSecurity/success
    buildrelease_test.go:705: task Select source spec: started
    buildrelease_test.go:705: task Read security ref: started
    buildrelease_test.go:705: task Timestamp release: started
    buildrelease_test.go:705: task Check branch state matches source archive: started
    buildrelease_test.go:705: task Wait for version CL submission: started
    buildrelease_test.go:705: task Wait for advisory builders: started
    buildrelease_test.go:705: task Tag version: started
    buildrelease_test.go:705: task Generate VERSION file: started
    buildrelease_test.go:705: task Push issues: started
...
    buildrelease_test.go:705: task Publish to website: started
    buildrelease_test.go:705: task Start Google Docker build: started
    buildrelease_test.go:724: task Publish to website: LOG: Published "go1.18rc1.src.tar.gz".
    buildrelease_test.go:724: task Publish to website: LOG: Published all 1 files for go1.18rc1.
    buildrelease_test.go:709: task Start Google Docker build: done: {docker-build-project build-1976034929531293877 }
    buildrelease_test.go:705: task Await Google Docker build: started
    buildrelease_test.go:709: task Publish to website: done: {go1.18rc1 [{go1.18rc1.src.tar.gz   go1.18rc1 866cd3a4fe047a829796d9afad6e9349244936ac1ecb424089d805775956e84a 1398 source}]}
    buildrelease_test.go:709: task Await Google Docker build: done: here's some build detail
    testing.go:1398: race detected during execution of test
--- FAIL: TestSecurity/success (1.11s)

— watchflakes

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Dec 5, 2024
@gopherbot gopherbot added this to the Unreleased milestone Dec 5, 2024
@dmitshur dmitshur self-assigned this Dec 7, 2024
@dmitshur dmitshur moved this to Active in Test Flakes Dec 7, 2024
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. FixPending Issues that have a fix which has not yet been reviewed or submitted. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Dec 7, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/634355 mentions this issue: internal/task: synchronize FakeGerrit.changes access

@github-project-automation github-project-automation bot moved this from Active to Done in Test Flakes Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitshur dmitshur

Labels
Builders x/build issues (builders, bots, dashboards) FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot