Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/exp/apidiff: support for go/types.Alias #70695

Open
timothy-king opened this issue Dec 5, 2024 · 2 comments
Open

x/exp/apidiff: support for go/types.Alias #70695

timothy-king opened this issue Dec 5, 2024 · 2 comments
Assignees
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@timothy-king
Copy link
Contributor

golang.org/x/exp/apidiff should be updated to support go/types producing Alias nodes. This is required for these tools to type check input code containing type parameterized alias nodes (1.24).

Additionally golang.org/x/exp/cmd/{apidiff, gorelease} should have the gotypesalias=1 GODEBUG setting enabled by default when built with a toolchain >= 1.24. See https://go.dev/cl/627715 for an example of how to do this.

See #69772 for additional context.

@timothy-king timothy-king added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 5, 2024
@timothy-king timothy-king added this to the Go1.24 milestone Dec 5, 2024
@gabyhelp
Copy link

gabyhelp commented Dec 5, 2024

@adonovan
Copy link
Member

adonovan commented Dec 5, 2024

@jba

@jba jba self-assigned this Dec 5, 2024
@seankhliao seankhliao changed the title golang.org/x/exp/apidiff: support for go/types.Alias x/exp/apidiff: support for go/types.Alias Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

4 participants