x/pkgsite: multiple invalid HTML

[3052]

What is the URL of the page with the issue?

view-source:https://pkg.go.dev/41.neocities.org/text

What is your user agent?

Firefox

Screenshot

What did you see happen?

first is the double close tag:

https://github.com/golang/pkgsite/blob/dc08416c8122836b0f06f5b3025699f37e3d53b9/static/shared/header/header.tmpl#L27-L50

then space is removed on both sides, leading to attributes with no separating space:

https://github.com/golang/pkgsite/blob/dc08416c8122836b0f06f5b3025699f37e3d53b9/static/frontend/unit/main/_meta.tmpl#L61-L69

and another example actually hard coded:

https://github.com/golang/pkgsite/blob/dc08416c8122836b0f06f5b3025699f37e3d53b9/static/shared/footer/footer.tmpl#L142

What did you expect to see?

valid HTML

[gabyhelp]

Related Issues

• x/pkgsite: Formatting is broken for examples #46770 (closed)
• x/website: unclosed tag causes formating issues in the FAQ page #65381 (closed)
• x/pkgsite: '' is rendered as smart doublequotes in <pre> block #51807 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[findleyr]

Thank you for your diligence. It looks like you have already done the hard work of finding and root causing these problems. Would you like to fix them? We would welcome a contribution fixing these errors.

[3052]

I don't see that you're on the Go team...

[findleyr]

@3052 I'm not sure what you mean, but I am on the Go team.

[ianlancetaylor]

When I look at https://github.com/findleyr I see two organizations listed: Go and Googlers. @3052 Do you not see that? I wonder if there is some GitHub setting that hides it in some cases.

[jimmyfrasche]

I only see Go listed and if I repopen the profile in a private window I see neither.

[ianlancetaylor]

Huh, if I use a Chrome incognito window I don't see any organizations for @findleyr, and for myself I see only the SWIG organization. I just edited my visibility for the golang organization, which I did from the organization page, and now I see myself listed in that organization. So it seems to be up to each person, or each organization, whether to publicize their organization membership.

[3052]

WOW that is really annoying - I am a member of two as well - but both were private by default - so I just fixed myself

https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-your-membership-in-organizations/publicizing-or-hiding-organization-membership

[findleyr]

Thanks, I did not know that! I've made my Go membership public now.

[FuenRob]

Hello, can I make a contribution to solve this issue?

[Mahimachavalam009]

can i contribute?

[findleyr]

Hi @FuenRob and @Mahimachavalam009 we would welcome fixes for these issues.

I think one CL will do, so @FuenRob since you asked first could you please confirm you will work on it? If not, no worries; @Mahimachavalam009 can contribute in that case.

[FuenRob]

Yes @findleyr I want to contribute by solving this fix. Thanks.

Should I assign the issue?

[findleyr]

@FuenRob I already assigned it to you :)

[FuenRob]

Hi @findleyr

I've uploaded the changes via Gerrit. How can I link the change to this issue?

Here is the link to the change: https://go-review.googlesource.com/c/pkgsite/+/639075

Please, any problem or failure, do not hesitate to tell me to fix it.

[ianlancetaylor]

@FuenRob In repo's other than the main go repo, you should write

Fixes golang/go#70730

See https://go.dev/wiki/CommitMessage.

[gopherbot]

Change https://go.dev/cl/639075 mentions this issue: static/frontend: Fix misplaced span tags in header template