Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html/template: escaping of script tokens from json.Marshal errors is not case insensitive #70740

Closed
rolandshoemaker opened this issue Dec 9, 2024 · 2 comments
Assignees
Labels
NeedsFix The path to resolution is known, but the work has not been done. Security
Milestone

Comments

@rolandshoemaker
Copy link
Member

rolandshoemaker commented Dec 9, 2024

The fix for #65697 does not take case into account, only escaping the lower case </script.

This is a PUBLIC track security issue.

Thanks to Juho Forsén of Mattermost for reporting this issue.

@rolandshoemaker rolandshoemaker added Security NeedsFix The path to resolution is known, but the work has not been done. labels Dec 9, 2024
@rolandshoemaker rolandshoemaker self-assigned this Dec 9, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/634696 mentions this issue: html/template: escape script tags in JS errors case insensitively

@gabyhelp
Copy link

gabyhelp commented Dec 9, 2024

Related Code Changes

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@dmitshur dmitshur added this to the Go1.24 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix The path to resolution is known, but the work has not been done. Security
Projects
None yet
Development

No branches or pull requests

4 participants