crypto/ecdsa, crypto/tls, crypto/x509: many crypto tests are failing on s390x

[srinivas-pokala]

Go version

go version devel go1.24-a9922d096f Wed Dec 11 04:00:12 2024 +0000 linux/s390x

Output of go env in your module/workspace:

AR='ar'
CC='gcc'
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_ENABLED='1'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
CXX='g++'
GCCGO='gccgo'
GO111MODULE=''
GOARCH='s390x'
GOAUTH='netrc'
GOBIN='/root/go/bin'
GOCACHE='/root/.cache/go-build'
GODEBUG=''
GOENV='/root/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFIPS140='off'
GOFLAGS=''
GOHOSTARCH='s390x'
GOHOSTOS='linux'
GOINSECURE=''
GOMOD='/root/go_compiler/dev/go_src/src/go.mod'
GOMODCACHE='/root/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/root/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/root/go_compiler/dev/go_src'
GOSUMDB='sum.golang.org'
GOTELEMETRY='local'
GOTELEMETRYDIR='/root/.config/go/telemetry'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/root/go_compiler/dev/go_src/pkg/tool/linux_s390x'
GOVCS=''
GOVERSION='devel go1.24-a9922d096f Wed Dec 11 04:00:12 2024 +0000'
GOWORK=''
PKG_CONFIG='pkg-config'

What did you do?

cd src/crypto/ecdsa/
go test -v
cd src/crypto/tls
go test -v
cd src/crypto/x509
go test -v

What did you see happen?

ECDSA:
--- FAIL: TestSignAndVerify (0.15s)
--- FAIL: TestSignAndVerifyASN1 (0.09s)
--- FAIL: TestVectors (0.46s)
--- FAIL: TestZeroHashSignature (0.07s)
--- FAIL: TestRFC6979 (0.05s)

TLS:
--- FAIL: TestBogoSuite (0.66s)
--- FAIL: TestFIPSServerSignatureAndHash (0.52s)
--- FAIL: TestHandshakeClientECDHEECDSAAES (0.00s)
--- FAIL: TestHandshakeClientECDHEECDSAAESGCM (0.00s)
--- FAIL: TestHandshakeClientAES256GCMSHA384 (0.00s)
--- FAIL: TestHandshakeClientECDHEECDSAAES128CBCSHA256 (0.00s)
--- FAIL: TestHandshakeClientECDHEECDSAChaCha20 (0.00s)
--- FAIL: TestHandshakeClientECDSATLS13 (0.00s)
--- FAIL: TestHandshakeClientCertRSA (0.00s)
--- FAIL: TestHandshakeClientCertECDSA (0.00s)
--- FAIL: TestHandshakeServerECDHEECDSAAES (0.00s)
--- FAIL: TestClientAuth (0.00s)

x509:
--- FAIL: TestECDSA (0.00s)
--- FAIL: TestCreateCertificateRequest (0.06s)

What did you expect to see?

All tests pass

[gabyhelp]

Related Issues

• crypto/ecdsa: buffers are too small, can cause panic on s390x #34927 (closed)
• crypto/ecdsa: TestRFC6979 failures on s390x #70660
• crypto/x509: can't verify signature on RSA-PSS certificate requests it created #45990 (closed)
• x/crypto/ocsp: TestOCSPDecode broken since CL 359777 #49443 (closed)
• retrieving external modules on Go1.15 on s390x appears to have checksum and ECDSA verification issues #40949 (closed)
• cmd/asm: aes related tests fail with SIGILL on z13 #63387 (closed)
• x/crypto/sha3: build failure on linux/s390x at Go master due to illegal instruction #36459 (closed)
• crypto/x509: invalid certificate policies #65990 (closed)
• crypto/ecdsa: signature verification succeeds when it should fail #42340 (closed)

Related Code Changes

• crypto/ecdsa,crypto/elliptic: improve tests and benchmarks

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[srinivas-pokala]

#70660

[srinivas-pokala]

/cc @FiloSottile

[cagedmantis]

cc @FiloSottile @rolandshoemaker @golang/security

[gopherbot]

Change https://go.dev/cl/636015 mentions this issue: crypto/ecdsa: fix s390x assembly with P-521