x/tools/gopls: report if accepting a completion item will result in auto-import

[xzbdmw]

gopls version

0.17.1

go env

..

What did you do?

"os" is not yet imported:

however, strings are already imported:

What did you see happen?

They looks the same.

What did you expect to see?

Show a hint whether a package is going to be auto-imported, because some package names look similar, I want to use an already imported one, but find myself often accept a wrong name, therefor need to undo auto import.

In clangd, there is a little circle indicating this:

after accpeting printf, the circle disappears, because stdio.h is auto imported

Editor and settings

No response

Logs

No response

[findleyr]

Thanks. Coincidentally, I am working on unimported completion, so I will look into this.

Off the top of my head, I do not know what causes the cdot for the clang analyzer, but I can investigate. This is VS Code, right?

[xzbdmw]

Yes, the circle is part of the returned completion item
https://clangd.llvm.org/features#namespace-and-include-insertion
that's what printf returns if it is going to import

{
  additionalTextEdits = { {
      newText = "#include <stdio.h>\n",
      range = {
        ["end"] = {
          character = 0,
          line = 6
        },
        start = {
          character = 0,
          line = 6
        }
      }
    } },
  detail = "int",
  documentation = {
    kind = "markdown",
    value = "From `<stdio.h>`"
  },
  filterText = "printf",
  insertText = "printf(${1:const char *, ...})",
  insertTextFormat = 2,
  kind = 3,
  label = "•printf",
  labelDetails = {
    detail = "(const char *, ...)"
  },
  score = 0.50908720493317,
  sortText = "40fdac76printf",
  textEdit = {
    newText = "printf(${1:const char *, ...})",
    range = {
      ["end"] = {
        character = 5,
        line = 13
      },
      start = {
        character = 4,
        line = 13
      }
    }
  }
}