Skip to content

x/tools/internal/refactor/inline: TestData/assignment.txtar failures #71040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gopherbot opened this issue Dec 27, 2024 · 2 comments
Closed

x/tools/internal/refactor/inline: TestData/assignment.txtar failures #71040

gopherbot opened this issue Dec 27, 2024 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "golang.org/x/tools/internal/refactor/inline" && test == "TestData/assignment.txtar"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestData/assignment.txtar
=== PAUSE TestData/assignment.txtar
=== CONT  TestData/assignment.txtar
    callee.go:100: analyzeCallee func testdata/b.B1() (testdata/c.C, int) @ /home/swarming/.swarming/w/ir/x/t/TestDataassignment.txtar1924800566/001/b/b.go:7:1
    callee.go:508: effects list = []
    falcon.go:179: falcon: emit type int۰0 int // "int"
    falcon.go:179: falcon: emit type int۰1 int // "testdata/c.C"
    inline.go:95: inline b.B1() @ /home/swarming/.swarming/w/ir/x/t/TestDataassignment.txtar1924800566/001/a/a1.go:7:14
    inline.go:582: multiple-assignment vars: map[var y int:true]
    inline.go:706: adding import c "testdata/c"
...
    inline.go:706: adding import c0 "testdata/c2"
    inline.go:822: - replace id "c1" @ #11 to "c"
    inline.go:822: - replace id "c2" @ #17 to "c0"
    inline.go:1931: falcon env: type int۰0 int
    inline.go:1931: falcon env: type int۰1 int
    inline.go:1931: falcon env: type int۰2 int
    inline.go:2381: binding decl not needed: all parameters substituted
    inline.go:3662: substrategy: convert assignment
    inline.go:1155: strategy: reduce assign-context call to { return exprs }
--- FAIL: TestData/assignment.txtar (59.36s)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 27, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/internal/refactor/inline" && test == "TestData/assignment.txtar"
2024-12-24 14:10 x_tools-go1.24-netbsd-arm tools@732f823c release-branch.go1.24@16afa6a7 x/tools/internal/refactor/inline.TestData/assignment.txtar (log)
=== RUN   TestData/assignment.txtar
=== PAUSE TestData/assignment.txtar
=== CONT  TestData/assignment.txtar
    callee.go:100: analyzeCallee func testdata/b.B1() (testdata/c.C, int) @ /home/swarming/.swarming/w/ir/x/t/TestDataassignment.txtar1924800566/001/b/b.go:7:1
    callee.go:508: effects list = []
    falcon.go:179: falcon: emit type int۰0 int // "int"
    falcon.go:179: falcon: emit type int۰1 int // "testdata/c.C"
    inline.go:95: inline b.B1() @ /home/swarming/.swarming/w/ir/x/t/TestDataassignment.txtar1924800566/001/a/a1.go:7:14
    inline.go:582: multiple-assignment vars: map[var y int:true]
    inline.go:706: adding import c "testdata/c"
...
    inline.go:706: adding import c0 "testdata/c2"
    inline.go:822: - replace id "c1" @ #11 to "c"
    inline.go:822: - replace id "c2" @ #17 to "c0"
    inline.go:1931: falcon env: type int۰0 int
    inline.go:1931: falcon env: type int۰1 int
    inline.go:1931: falcon env: type int۰2 int
    inline.go:2381: binding decl not needed: all parameters substituted
    inline.go:3662: substrategy: convert assignment
    inline.go:1155: strategy: reduce assign-context call to { return exprs }
--- FAIL: TestData/assignment.txtar (59.36s)

watchflakes

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Dec 27, 2024
@gopherbot gopherbot added this to the Unreleased milestone Dec 27, 2024
@adonovan
Copy link
Member

Dup of #70492

@adonovan adonovan closed this as not planned Won't fix, can't repro, duplicate, stale Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Archived in project
Development

No branches or pull requests

2 participants