Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: TestRootConcurrentClose fails when runtime.AddCleanup is used #71117

Open
cagedmantis opened this issue Jan 3, 2025 · 2 comments
Open

os: TestRootConcurrentClose fails when runtime.AddCleanup is used #71117

cagedmantis opened this issue Jan 3, 2025 · 2 comments
Assignees
@cagedmantis
Labels
arch-wasm WebAssembly issues BugReport Issues describing a possible bug in the Go implementation. compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@cagedmantis
Copy link
Contributor

cagedmantis commented Jan 3, 2025 •
edited
Loading

While in the process of replacing the use of runtime.SetFinalizer with runtime.AddCleanup (#70907) in the os package, the TestRootConcurrentClose tests started failing. An investigation into the build error on go.dev/cl/638555 showed that on the gotip-wasip1-wasm_wazero builder, TestRootConcurrentClose fails because the goroutine that is spawned runs continuously and never allows the the original goroutine to continue processing.

Umbrella issue: #71134

@golang/wasm
@cagedmantis cagedmantis added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-wasm WebAssembly issues compiler/runtime Issues related to the Go compiler and/or runtime. labels Jan 3, 2025
@gabyhelp
Copy link

gabyhelp commented Jan 3, 2025

Related Code Changes

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@dmitshur dmitshur added this to the Backlog milestone Jan 3, 2025
@gabyhelp gabyhelp added the Bug label Jan 6, 2025
@mknyszek mknyszek moved this to In Progress in Go Compiler / Runtime Jan 8, 2025
@cagedmantis
Copy link
Contributor Author

Umbrella issue: #71134

@jba jba added BugReport Issues describing a possible bug in the Go implementation. and removed Bug labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagedmantis cagedmantis

Labels
arch-wasm WebAssembly issues BugReport Issues describing a possible bug in the Go implementation. compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Compiler / Runtime
Status: In Progress
Milestone
Backlog
Development

No branches or pull requests
4 participants
@cagedmantis @dmitshur @jba @gabyhelp