Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: broken write barrier [1.22 backport] #71229

Closed
gopherbot opened this issue Jan 11, 2025 · 2 comments
Closed

cmd/compile: broken write barrier [1.22 backport] #71229

gopherbot opened this issue Jan 11, 2025 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.22.12

Comments

@gopherbot
Copy link
Contributor

@randall77 requested issue #71228 to be considered for backport to the next 1.22 minor release.

@gopherbot please open backport issues.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 11, 2025
@gopherbot gopherbot mentioned this issue Jan 11, 2025
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jan 11, 2025
@gopherbot gopherbot added this to the Go1.22.11 milestone Jan 11, 2025
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/642499 mentions this issue: [release-branch.go1.22] cmd/compile: fix write barrier coalescing

@mknyszek mknyszek added the CherryPickApproved Used during the release process for point releases label Jan 15, 2025
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jan 15, 2025
@gopherbot gopherbot modified the milestones: Go1.22.11, Go1.22.12 Jan 16, 2025
gopherbot pushed a commit that referenced this issue Jan 17, 2025
@randall77 @mknyszek
[release-branch.go1.22] cmd/compile: fix write barrier coalescing
e0a01ac 
We can't coalesce a non-WB store with a subsequent Move, as the
result of the store might be the source of the move.

There's a simple codegen test. Not sure how we might do a real test,
as all the repro's I've come up with are very expensive and unreliable.

Fixes #71229

Change-Id: If18bf181a266b9b90964e2591cd2e61a7168371c
Reviewed-on: https://go-review.googlesource.com/c/go/+/642197
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/642499
@gopherbot
Copy link
Contributor Author

Closed by merging CL 642499 (commit e0a01ac) to release-branch.go1.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.22.12
Development

No branches or pull requests
2 participants
@mknyszek @gopherbot