Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: package removal request for (case sensitive) https://pkg.go.dev/github.com/ibm/sarama #71342

Closed
dnwe opened this issue Jan 20, 2025 · 10 comments
Assignees
Labels
pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Milestone

Comments

@dnwe
Copy link

dnwe commented Jan 20, 2025

What is the path of the package that you would like to have removed?

github.com/ibm/sarama (case sensitive)

Are you the owner of this package?

Yes I am the owner of this package under the IBM org.

What is the reason that you could not retract this package instead?

This is a follow-on from #71256 where under https://go.dev/cl/642600 I added ibm/sarama --> IBM/sarama under the knownAlternatives mechanism in pkgsite, which corrects things at the fetch level, but it looks like the historically fetched data needs to be purged

pkgsite seems to accidentally have an invalid (and outdated) lowercase entry at https://pkg.go.dev/github.com/ibm/sarama whereas the correct module path is https://pkg.go.dev/github.com/IBM/sarama which is correct an up-to-date.

Please can you remove the invalid lowercase entry at https://pkg.go.dev/github.com/ibm/sarama (whilst retaining/keeping the uppercase IBM entry at https://pkg.go.dev/github.com/IBM/sarama)

@dnwe dnwe added the pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package label Jan 20, 2025
@gopherbot gopherbot added this to the Unreleased milestone Jan 20, 2025
@gabyhelp
Copy link

@adonovan
Copy link
Member

I think the problem here may just be the (usual) delay in propagation of the configuration change we already made.

@dnwe
Copy link
Author

dnwe commented Jan 24, 2025

@adonovan thats what I originally thought, but then I checked the old Shopify one (which this CL was based upon the premise of) and that lowercase variant “shopify” still exists for older versions (which I assume were cached before the alias was added) and aren’t redirected to their canonical Shopify casing

https://pkg.go.dev/github.com/shopify/sarama
https://pkg.go.dev/github.com/Shopify/sarama

@jba
Copy link
Contributor

jba commented Jan 30, 2025

github.com/ibm/sarama is excluded. It may take a few minutes for the cache to time out.

@jba jba closed this as completed Jan 30, 2025
@dnwe
Copy link
Author

dnwe commented Jan 30, 2025

@jba sadly this seems to have now delisted both https://pkg.go.dev/github.com/ibm/sarama and https://pkg.go.dev/github.com/IBM/sarama 😔

@jba
Copy link
Contributor

jba commented Jan 31, 2025

Yup, I missed that exclusion from GitHub is case-insensitive.
I'm going to restore both for now, and work on the right fix.
Sorry about that.

@jba
Copy link
Contributor

jba commented Jan 31, 2025

Both are now restored.

@jba jba reopened this Jan 31, 2025
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/645636 mentions this issue: internal/frontend: exclude paths case-sensitively

@jba
Copy link
Contributor

jba commented Jan 31, 2025

That CL should fix it, but won't take effect until the next deployment, which should be early next week.

gopherbot pushed a commit to golang/pkgsite that referenced this issue Jan 31, 2025
Provide a way to exclude paths exactly (case-sensitively).
The usual exclusion mechanism is case-insensitive, which is a problem
for those who want to exclude only particular casings of their module.
For example, IBM would like their name in all caps, but some older
packages were published under "ibm".

Exclude "github.com/ibm/sarama".

For golang/go#71342.

Change-Id: I848e261458013e364f850daf6474ba6fd7136f25
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/645636
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
@dnwe
Copy link
Author

dnwe commented Feb 5, 2025

Thanks! It looks great now

@dnwe dnwe closed this as completed Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Projects
None yet
Development

No branches or pull requests

5 participants