-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/pkgsite: package removal request for (case sensitive) https://pkg.go.dev/github.com/ibm/sarama #71342
Comments
Related Issues
(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.) |
I think the problem here may just be the (usual) delay in propagation of the configuration change we already made. |
@adonovan thats what I originally thought, but then I checked the old Shopify one (which this CL was based upon the premise of) and that lowercase variant “shopify” still exists for older versions (which I assume were cached before the alias was added) and aren’t redirected to their canonical Shopify casing https://pkg.go.dev/github.com/shopify/sarama |
github.com/ibm/sarama is excluded. It may take a few minutes for the cache to time out. |
@jba sadly this seems to have now delisted both https://pkg.go.dev/github.com/ibm/sarama and https://pkg.go.dev/github.com/IBM/sarama 😔 |
Yup, I missed that exclusion from GitHub is case-insensitive. |
Both are now restored. |
Change https://go.dev/cl/645636 mentions this issue: |
That CL should fix it, but won't take effect until the next deployment, which should be early next week. |
Provide a way to exclude paths exactly (case-sensitively). The usual exclusion mechanism is case-insensitive, which is a problem for those who want to exclude only particular casings of their module. For example, IBM would like their name in all caps, but some older packages were published under "ibm". Exclude "github.com/ibm/sarama". For golang/go#71342. Change-Id: I848e261458013e364f850daf6474ba6fd7136f25 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/645636 Reviewed-by: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
Thanks! It looks great now |
What is the path of the package that you would like to have removed?
github.com/ibm/sarama (case sensitive)
Are you the owner of this package?
Yes I am the owner of this package under the IBM org.
What is the reason that you could not retract this package instead?
This is a follow-on from #71256 where under https://go.dev/cl/642600 I added ibm/sarama --> IBM/sarama under the
knownAlternatives
mechanism in pkgsite, which corrects things at the fetch level, but it looks like the historically fetched data needs to be purgedpkgsite seems to accidentally have an invalid (and outdated) lowercase entry at https://pkg.go.dev/github.com/ibm/sarama whereas the correct module path is https://pkg.go.dev/github.com/IBM/sarama which is correct an up-to-date.
Please can you remove the invalid lowercase entry at https://pkg.go.dev/github.com/ibm/sarama (whilst retaining/keeping the uppercase IBM entry at https://pkg.go.dev/github.com/IBM/sarama)
The text was updated successfully, but these errors were encountered: