x/tools/gopls: "missing reachable node for %q" bug in evaluatePackageHandle

[adonovan]

#!stacks
"bug.Reportf" && "evaluatePackageHandle.func2:+4"

Issue created by stacks.

		// Collect reachable nodes.
		var reachableNodes []*handleNode
		// In the presence of context cancellation, any package may be missing.
		// We need all dependencies to produce a key.
		reachable.Elems(func(id typerefs.IndexID) {
			dh := b.nodes[id]
			if dh == nil {
				// Previous code reported an error (not a bug) here.
				bug.Reportf("missing reachable node for %q", id) <---------- here
			} else {
				reachableNodes = append(reachableNodes, dh)
			}
		})

This stack HFIUJQ was reported by telemetry:

• gopls/bug
• golang.org/x/tools/gopls/internal/util/bug.report:+35
• golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
• golang.org/x/tools/gopls/internal/cache.(*packageHandleBuilder).evaluatePackageHandle.func2:+4
• golang.org/x/tools/gopls/internal/cache/typerefs.(*PackageSet).Elems:+10
• golang.org/x/tools/gopls/internal/cache.(*packageHandleBuilder).evaluatePackageHandle:+140
• golang.org/x/tools/gopls/internal/cache.(*Snapshot).getPackageHandles.func2.1:+8
• golang.org/x/sync/errgroup.(*Group).Go.func1:+3
• runtime.goexit:+0

golang.org/x/tools/gopls@v0.17.1 go1.23.4 linux/amd64 vscode (1)
golang.org/x/tools/gopls@v0.17.1 go1.23.2 linux/amd64 vscode (2)

Dups: UHdPEQ ghFsGQ awlzOQ

[gabyhelp]

Related Issues

• x/tools/gopls: "missing reference to package %s" bug in getOneTransitiveRefLocked #71354
• x/tools/gopls: "nil handle" assert in getPackageHandles #71353
• x/tools/gopls: nil deref in evaluatePackageHandle (telemetry) #69236 (closed)
• x/tools/gopls: "go/packages failed to return non-test standalone package" bug (reported by telemetry) #66204 (closed)
• x/tools/gopls: bug reported by telemetry [qoVPwQ] #64243 (closed)
• x/tools/gopls: bug: load.go:185: go/packages returned unexpected package "golang.org/x/tools/go/callgraph/cha/testdata/iface.go.master" for standalone file #69331 (closed)
• x/tools/gopls: crash in packageReferences (reported by telemetry) #66250 (closed)
• x/tools/gopls: "package name is %q, want %q" bug in typeCheckBatch.importPackage #64235
• x/tools/gopls: "go/packages returned unexpected package %q for standalone file" bug in Snapshot.load #69895 (closed)
• x/tools/gopls: Hover: nil deref in parseDocLink #70635 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}